-
Notifications
You must be signed in to change notification settings - Fork 3k
Netbeans Exporter Bugfix #5901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netbeans Exporter Bugfix #5901
Conversation
Automatic CI verification build not done, please verify manually. |
tools/export/nb/__init__.py
Outdated
matched.append(element) | ||
# Compare the Element in Previous Dir with the Elements in Current Dir | ||
# and add the Differences to the match-List | ||
if len(dir_list) <= len(prev_dir_list): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer this implemented as:
for prev_dir, cur_dir in zip(prev_dir_list, dir_list):
if cur_dir == prev_dir:
...
With that, you don't need the if statement. zip
will terminate when either list ends; docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for that, didn't know that this can be done much easier! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to apologize; that's what review is for.
…d-in function zip()
# and add the equal Elements to the match-List | ||
for elem_prev_dir, elem_cur_dir in zip(prev_dir_list, dir_list): | ||
if elem_prev_dir == elem_cur_dir: | ||
matched.append(elem_cur_dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of elem
in these variable names dose not add any meaning for me. I would like to seem them removed, but I won't block this PR for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remove the prefix elem
it will not work as expected, because the variables prev_dir and cur_dir are already defined in scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's part of why I would like another name: the current name is almost a name clash. Like I said, not blocking just a wish. Let me know if you come up with something.
/morph build |
1 similar comment
/morph build |
Build : SUCCESSBuild number : 967 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 654 |
Test : SUCCESSBuild number : 795 |
Holding off on reissuing test. uVisor build CI has been experiencing an odd issue across multiple PRs today. |
/morph uvisor-test |
Description
Fixed a bug on multiple Sub-Directories with same name.
Was not discovered correctly before.
Problem occured on path with same name like:
storage/filesystem/littlefs/littlefs
Status
READY
Steps to test or reproduce
mbed export -i netbeans