Skip to content

Netbeans Exporter Bugfix #5901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2018
Merged

Netbeans Exporter Bugfix #5901

merged 2 commits into from
Jan 29, 2018

Conversation

cmens23
Copy link

@cmens23 cmens23 commented Jan 23, 2018

Description

Fixed a bug on multiple Sub-Directories with same name.
Was not discovered correctly before.

Problem occured on path with same name like:
storage/filesystem/littlefs/littlefs

Status

READY

Steps to test or reproduce

mbed export -i netbeans

@mbed-ci
Copy link

mbed-ci commented Jan 23, 2018

Automatic CI verification build not done, please verify manually.

matched.append(element)
# Compare the Element in Previous Dir with the Elements in Current Dir
# and add the Differences to the match-List
if len(dir_list) <= len(prev_dir_list):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this implemented as:

for prev_dir, cur_dir in zip(prev_dir_list, dir_list):
    if cur_dir == prev_dir:
        ...

With that, you don't need the if statement. zip will terminate when either list ends; docs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that, didn't know that this can be done much easier! Thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to apologize; that's what review is for.

# and add the equal Elements to the match-List
for elem_prev_dir, elem_cur_dir in zip(prev_dir_list, dir_list):
if elem_prev_dir == elem_cur_dir:
matched.append(elem_cur_dir)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of elem in these variable names dose not add any meaning for me. I would like to seem them removed, but I won't block this PR for it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remove the prefix elem it will not work as expected, because the variables prev_dir and cur_dir are already defined in scope.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's part of why I would like another name: the current name is almost a name clash. Like I said, not blocking just a wish. Let me know if you come up with something.

@cmonr
Copy link
Contributor

cmonr commented Jan 25, 2018

/morph build

1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 26, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 26, 2018

Build : SUCCESS

Build number : 967
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5901/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 26, 2018

@mbed-ci
Copy link

mbed-ci commented Jan 26, 2018

@cmonr
Copy link
Contributor

cmonr commented Jan 26, 2018

Holding off on reissuing test. uVisor build CI has been experiencing an odd issue across multiple PRs today.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 29, 2018

/morph uvisor-test

@cmonr cmonr merged commit cf5065c into ARMmbed:master Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants