New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for STM32L443RC & WISE-1510 #5904

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
5 participants
@ithinuel
Member

ithinuel commented Jan 23, 2018

Description

This PR add support for the STM32L443RC and the WISE-1510 module.
This was tested with @kivaisan on mbed-os-example-lora

Status

MERGED

Todos

  • Tests
  • Documentation

@ithinuel ithinuel changed the title from add basic support for STM32L443RC & WISE-1510 to add support for STM32L443RC & WISE-1510 Jan 23, 2018

@@ -1472,6 +1472,23 @@
"release_versions": ["2", "5"],
"device_name": "STM32L433RC",
"bootloader_supported": true
},
"WISE_1510": {

This comment has been minimized.

@0xc0170

0xc0170 Jan 23, 2018

Member

no release version? will be added later?

This comment has been minimized.

@ithinuel

ithinuel Jan 23, 2018

Member

I'm not sure about which revision it's aiming.
Should it be current 5.7 or next release 5.8 ?

This comment has been minimized.

@0xc0170

0xc0170 Jan 23, 2018

Member

release_versions can be 2 or 5 or both. I assume 5 should be defined here

This comment has been minimized.

@ithinuel

ithinuel Jan 23, 2018

Member

oh, ok, I add it now.

@jeromecoutant

Hi
Here is a quick review
Thx

.gitignore Outdated
@@ -72,6 +72,9 @@ debug.log
# Cscope
cscope.*

# Ctags
tags

This comment has been minimized.

@jeromecoutant

jeromecoutant Jan 24, 2018

Contributor

Not related to the PR

This comment has been minimized.

@0xc0170

0xc0170 Jan 24, 2018

Member

Should be sent via separate PR

.ANY (+RO)
}

RW_IRAM1 0x20000000 0x0000C000 { ; RW data 48k L4-SRAM1

This comment has been minimized.

@jeromecoutant

jeromecoutant Jan 24, 2018

Contributor

In STM32L443, SRAM2 and SRAM1 and continuous.
You can prefer to get a bigger SRAM1. See #5171

This comment has been minimized.

@ithinuel

ithinuel Jan 24, 2018

Member

These two ranges offer different features namely the hardware parity check and the standby retain mode on SRAM2.
In order to let the end-user free to choose to use it or not, shouldn't we rather add a special section to allow this use case and avoid the user to tweak the linker script him/herself ?

{
FLASH (rx) : ORIGIN = MBED_APP_START, LENGTH = MBED_APP_SIZE
SRAM2 (rwx) : ORIGIN = 0x1000018C, LENGTH = 16k - 0x18C
SRAM1 (rwx) : ORIGIN = 0x20000000, LENGTH = 48k

This comment has been minimized.

@jeromecoutant

jeromecoutant Jan 24, 2018

Contributor

Same comment, you can increase RAM size from 48k to 64k

}
},
"release_versions": ["5"],
"device_has_add": ["ANALOGOUT", "LOWPOWERTIMER", "SERIAL_FC", "SERIAL_ASYNCH", "CAN", "TRNG", "FLASH", "AES"],

This comment has been minimized.

@jeromecoutant

jeromecoutant Jan 24, 2018

Contributor

DEVICE_AES doesn't exist ?

This comment has been minimized.

@ithinuel

ithinuel Jan 24, 2018

Member

Should it be the macro MBEDTLS_CONFIG_HW_SUPPORT instead ?

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jan 24, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 24, 2018

Please check travis failures

@ithinuel ithinuel force-pushed the ithinuel:add-wise-1510 branch 2 times, most recently from 6feedfe to 3e5df16 Jan 24, 2018

@ithinuel

This comment has been minimized.

Member

ithinuel commented Jan 26, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 26, 2018

Build : SUCCESS

Build number : 971
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5904/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@ithinuel ithinuel force-pushed the ithinuel:add-wise-1510 branch from 3e5df16 to db5ec9c Jan 26, 2018

@ithinuel ithinuel force-pushed the ithinuel:add-wise-1510 branch from db5ec9c to e6b19d8 Jan 26, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 29, 2018

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 29, 2018

@jeromecoutant Are you good with the latest commits for this PR?

@cmonr cmonr added needs: review and removed needs: work labels Jan 29, 2018

@jeromecoutant

Increase RAM size from 48k to 64k is optional, and can be checked later.

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 29, 2018

Build : SUCCESS

Build number : 991
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5904/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 30, 2018

/morph uvisor-test

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jan 30, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 30, 2018

/morph uvisor-test

@ithinuel

This comment has been minimized.

Member

ithinuel commented Jan 30, 2018

All green 🕺 !

@cmonr cmonr merged commit b87e98c into ARMmbed:master Jan 30, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@ithinuel ithinuel deleted the ithinuel:add-wise-1510 branch Jan 30, 2018

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 30, 2018

@ithinuel Not sure why the above exporter build just ran. If we need some sort of action from you, we'll let you know.

@ithinuel

This comment has been minimized.

Member

ithinuel commented Jan 30, 2018

Ok, no problem, you know where I stand 😉

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 30, 2018

@ithinuel It looks like this PR + #5947 + some unfortunate timing is causing the new build issues.

I'm going to move forward with the revert PR, and once it passes all of its tests, merge it in. After it's merged in, I'd like you to restore your branch, and create a new PR.

The issue appears to have been the timing that the morph build commands occurred between the two PRs.

@ithinuel ithinuel restored the ithinuel:add-wise-1510 branch Jan 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment