Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes around MBED_BOT parameter #6125

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Feb 16, 2018

Description

If $MBED_BOT is not configured in Travis (ie: if mbed-os is forked and the user had not setup a token yet), the build will fail in a non-obvious way.

Status

READY

Copy link
Contributor

@geky geky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@geky
Copy link
Contributor

geky commented Feb 16, 2018

Does this mean if MBED_BOT is not set the build will still pass?

@cmonr
Copy link
Contributor Author

cmonr commented Feb 17, 2018

@geky Nope. The command will look like --user --request POST <URL> which will mess up the command and fail the build with something odd/nonsensical.

@geky
Copy link
Contributor

geky commented Feb 17, 2018

Ah I meant with the quotes

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 19, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 19, 2018

Build : SUCCESS

Build number : 1169
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6125/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Feb 19, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 19, 2018

@0xc0170 0xc0170 changed the title Added quotes around MBED_BOT parameter Add quotes around MBED_BOT parameter Feb 21, 2018
@0xc0170 0xc0170 merged commit 4cf53fe into ARMmbed:master Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants