New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes around MBED_BOT parameter #6125

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
4 participants
@cmonr
Contributor

cmonr commented Feb 16, 2018

Description

If $MBED_BOT is not configured in Travis (ie: if mbed-os is forked and the user had not setup a token yet), the build will fail in a non-obvious way.

Status

READY

@cmonr cmonr requested review from geky and 0xc0170 Feb 16, 2018

@cmonr cmonr added the needs: review label Feb 16, 2018

@geky

geky approved these changes Feb 16, 2018

Good catch

@geky

This comment has been minimized.

Member

geky commented Feb 16, 2018

Does this mean if MBED_BOT is not set the build will still pass?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 17, 2018

@geky Nope. The command will look like --user --request POST <URL> which will mess up the command and fail the build with something odd/nonsensical.

@geky

This comment has been minimized.

Member

geky commented Feb 17, 2018

Ah I meant with the quotes

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 19, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 19, 2018

Build : SUCCESS

Build number : 1169
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6125/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Feb 20, 2018

@0xc0170 0xc0170 changed the title from Added quotes around MBED_BOT parameter to Add quotes around MBED_BOT parameter Feb 21, 2018

@0xc0170 0xc0170 merged commit 4cf53fe into ARMmbed:master Feb 21, 2018

18 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mbed-ci-generic Build finished.
Details
travis-ci/docs/ Local docs testing has passed
Details
travis-ci/events/ Local events testing has passed
Details
travis-ci/littlefs/ Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL/ Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM/ Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC/ Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON/ Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP/ Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS/ Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM/ Local mbed2-STM testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment