/mbed-os

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifying datarate bug fix #6141

Merged
merged 1 commit into from Feb 20, 2018

Conversation

Reviewers

@0xc0170 0xc0170

@kivaisan kivaisan

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
6 participants
@hasnainvirk @0xc0170 @mbed-ci @adbridge @kivaisan @cmonr
@hasnainvirk
Contributor

hasnainvirk commented Feb 20, 2018 •
edited

A patch was missed from the feature PR.
verify_channel_DR() in LoRaPHY class had a loop with uninitialized
loop counter.

Status

READY

Migrations

NO
@hasnainvirk
Verifying datarate bug fix 
A patch was missed from the feature PR.
verify_channel_DR() in LoRaPHY class had a loop with uninitialized
loop counter.
Loading status checks…
b163057
@hasnainvirk

This comment has been minimized.

Sign in to view
Contributor

hasnainvirk commented Feb 20, 2018

@kivaisan @0xc0170 Please review.
@0xc0170

0xc0170 approved these changes Feb 20, 2018
View changes

@0xc0170

This comment has been minimized.

Sign in to view
Member

0xc0170 commented Feb 20, 2018

/morph build
@kivaisan

kivaisan approved these changes Feb 20, 2018
View changes

@0xc0170 0xc0170 added the needs: CI label Feb 20, 2018

@mbed-ci

This comment has been minimized.

Sign in to view

mbed-ci commented Feb 20, 2018

Build : SUCCESS

Build number : 1181
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6141/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build
@mbed-ci

This comment has been minimized.

Sign in to view

mbed-ci commented Feb 20, 2018

Test : SUCCESS

Build number : 985
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6141/985
@mbed-ci

This comment has been minimized.

Sign in to view

mbed-ci commented Feb 20, 2018

Exporter Build : SUCCESS

Build number : 859
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6141/

@cmonr cmonr merged commit 24a3acd into ARMmbed:master Feb 20, 2018
18 checks passed

18 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mbed-ci-generic Build finished.
Details
travis-ci/docs/ Local docs testing has passed
Details
travis-ci/events/ Local events testing has passed
Details
travis-ci/littlefs/ Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL/ Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM/ Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC/ Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON/ Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP/ Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS/ Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM/ Local mbed2-STM testing has passed
Details

@cmonr cmonr added release-version: 5.7.6 and removed needs: CI labels Feb 20, 2018

@adbridge

This comment has been minimized.

Sign in to view
Contributor

adbridge commented Feb 23, 2018

This is reliant on #6087 which is a new feature for 5.8!

@adbridge adbridge added release-version: 5.8.0-rc1 and removed release-version: 5.7.6 labels Feb 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment