New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPC546XX: Add support for 220MHz core speed available on LPC54628 #6147

Merged
merged 2 commits into from Feb 23, 2018

Conversation

Projects
None yet
5 participants
@mmahadevan108
Contributor

mmahadevan108 commented Feb 20, 2018

Read the part ID at bootup and increase core speed to 220MHz on LPC54628

Status

**READY

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Feb 20, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 21, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 21, 2018

Build : SUCCESS

Build number : 1197
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6147/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Increase_Speed_LPC54628 branch from 453f217 to 668e124 Feb 21, 2018

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Feb 21, 2018

I have pushed in an update to fix the Exporter BUILD Failure.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 21, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 21, 2018

Build : SUCCESS

Build number : 1199
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6147/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 21, 2018

/morph uvisor-test

@gorazdko

This comment has been minimized.

Contributor

gorazdko commented Feb 21, 2018

@mmahadevan108 Can you cherry pick also

gorazdko@da46ce7

If the line is present the wait() function takes longer when adc enabled. What do you think?

@mbed-ci

This comment has been minimized.

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Feb 21, 2018

@gorazdko Can you provide details on why this change is required?

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Feb 21, 2018

@0xc0170 I am not clear why mbed-ci is failing

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 21, 2018

We will review the logs (seems based on the info I am seeing to me that this is CI failure but need to confirm).

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 21, 2018

I missed that you pushed an update we run CI, restarting

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 21, 2018

Build : SUCCESS

Build number : 1205
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6147/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Feb 21, 2018

@gorazdko I understand your change. Can you please submit a separate PR for your change. Thanks.

@gorazdko

This comment has been minimized.

Contributor

gorazdko commented Feb 21, 2018

@mmahadevan108 Ok I will. I will change this at 546xx and 54114

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Feb 21, 2018

@gorazdko Thank you.

@mbed-ci

This comment has been minimized.

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Feb 21, 2018

@0xc0170 I don't see this failure reported by mbed-ci. I am using

 IAR Command Line Build Utility V8.0.11.5069
 Copyright 2002-2017 IAR Systems AB.

mbed-ci is using

 IAR Command Line Build Utility V7.5.6.4719
 Copyright 2002-2017 IAR Systems AB.

Can you help update and try.

@gorazdko

This comment has been minimized.

Contributor

gorazdko commented Feb 21, 2018

@0xc0170 I see the "release_versions" in targets.json should be placed inside children afterall since now the parent (MCU_LPC546XX) is treated as a target. Will correct this next time. Hope this is not causing problems now.
screenshot from 2018-02-21 20-03-31

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 21, 2018

@mmahadevan108, it looks like the difference between our build tools is that you're building using v8 of IAR. At the moment, mbed-os and its tools do not support v8.

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Feb 21, 2018

@cmonr How do you suggest we proceed?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 21, 2018

@mmahadevan108 Is the LPC54628J512 only supported in IAR 8?

@cmonr cmonr added the needs: work label Feb 21, 2018

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Feb 22, 2018

Here is what I see in IAR release notes:

Device | Released
LPC54628J512 | 8.11.3

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 22, 2018

This has to wait for IAR update 8. If this is the case, exporting should not be enabled

mmahadevan108 added some commits Feb 20, 2018

LPC546XX: Add support for 220MHz core speed available on LPC54628
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
ff_lpc546xx: Add support for 220MHz core speed.
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Increase_Speed_LPC54628 branch from 668e124 to 069c80b Feb 22, 2018

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Feb 22, 2018

@0xc0170 @cmonr I have backed off the IAR change.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 22, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 22, 2018

Build : SUCCESS

Build number : 1221
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6147/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr added needs: CI and removed needs: work labels Feb 22, 2018

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Feb 23, 2018

@cmonr cmonr merged commit bf2f24f into ARMmbed:master Feb 23, 2018

18 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mbed-ci-generic Build finished.
Details
travis-ci/docs/ Local docs testing has passed
Details
travis-ci/events/ Local events testing has passed
Details
travis-ci/littlefs/ Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL/ Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM/ Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC/ Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON/ Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP/ Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS/ Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM/ Local mbed2-STM testing has passed
Details

@mmahadevan108 mmahadevan108 deleted the NXPmicro:Increase_Speed_LPC54628 branch Feb 23, 2018

@cmonr cmonr removed the ready for merge label Feb 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment