New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in the files #6149

Merged
merged 4 commits into from Mar 15, 2018

Conversation

Projects
None yet
8 participants
@bmcdonnell-ionx
Contributor

bmcdonnell-ionx commented Feb 21, 2018

Description

Fix a bunch of typos.

(I used grep/sed to find and fix repeats.)

Status

READY

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 21, 2018

--none--

@0xc0170 0xc0170 requested a review from AnotherButler Feb 21, 2018

@0xc0170 0xc0170 changed the title from typos to Fix typos in the files Feb 21, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 21, 2018

/morph build

@0xc0170

The most looks good, thanks for the fixes

What I would not touch are 3rd party code. They might get overwritten by the next updates.

@@ -1469,7 +1469,7 @@ void HAL_SAI_IRQHandler(SAI_HandleTypeDef *hsai)
uint32_t cr1config = hsai->Instance->CR1;
uint32_t tmperror;
/* SAI Fifo request interrupt occured ------------------------------------*/
/* SAI Fifo request interrupt occurred -----------------------------------*/

This comment has been minimized.

@0xc0170

0xc0170 Feb 21, 2018

Member

for 3rd party files, we should not change them for easier integration.

@ARMmbed/team-st-mcd Please review

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 21, 2018

Build : SUCCESS

Build number : 1192
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6149/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 21, 2018

We reviewed the changed files , we should not change 3rd party code.

Folders to apply to:

  • TESTS
  • drivers
  • events
  • features/filesystem/bd
  • features/filesystem/littlefs
  • features/netsocket
  • features/storage/FEATURE_STORAGE/cfstore
  • hal
  • platform
  • tools

Please leave any changes outside of these folders

@0xc0170 0xc0170 added needs: work and removed needs: review labels Feb 21, 2018

@bcostm

This comment has been minimized.

Contributor

bcostm commented Feb 21, 2018

we should not change 3rd party code

I agree. We will ask the "STM32Cube team" to take into account these typos. Thanks @bmcdonnell-ionx

@bmcdonnell-ionx

This comment has been minimized.

Contributor

bmcdonnell-ionx commented Feb 21, 2018

@bcostm,

We will ask the "STM32Cube team" to take into account these typos.

Does that account for all of the external code that I modified?

@bcostm

This comment has been minimized.

Contributor

bcostm commented Feb 21, 2018

Please do not change files placed in targets/TARGET_STM/*/device/* folders and also other vendors specific files. See the list given by @0xc0170 above. Thanks!

@bmcdonnell-ionx

This comment has been minimized.

Contributor

bmcdonnell-ionx commented Feb 22, 2018

For reference, the changes I reverted are in these folders, in case you want to try to push any of them upstream.

  • features/FEATURE_BLE/
  • features/FEATURE_LWIP/
  • features/filesystem/fat/ChaN/ff.cpp
  • features/lorawan/
  • features/mbedtls/
  • features/nanostack/
  • features/unsupported/USBDevice/
  • features/unsupported/tests/libs/SPIHalfDuplex/
  • targets/

@0xc0170 0xc0170 added needs: review and removed needs: work labels Feb 22, 2018

@AnotherButler

Great catches 👍

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 6, 2018

@studavekar This one worked.

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 6, 2018

Build : SUCCESS

Build number : 1350
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6149/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@bmcdonnell-ionx

This comment has been minimized.

Contributor

bmcdonnell-ionx commented Mar 6, 2018

Can someone interpret those CI failure for me? Is there something else I need to change?

@cmonr cmonr added the needs: CI label Mar 6, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 7, 2018

/morph mbed2-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 7, 2018

@bmcdonnell-ionx Buy a lotto ticket, you've hit the test bug 2/2 times!

/morph test

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 7, 2018

Since it seems that morph is now listening to me, going to relaunch the exporter build to get an all-green.
/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 7, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 7, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 8, 2018

/morph mbed2-build

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 8, 2018

@@ -555,7 +555,8 @@ fpu_init();
LPC_SC->CLKOUTCFG = CLKOUTCFG_Val; /* Clock Output Configuration */
#endif
LPC_SC->PBOOST |= 0x03; /* Power Boost control */
//TODO: verify correct operation w/ this setting. Refer to Table 18 in UM10562.pdf.

This comment has been minimized.

@0xc0170

0xc0170 Mar 8, 2018

Member

How this line got in? Was it bad rebase? I don't see this todo. And this PR was updated not to change targets/ code ?

This comment has been minimized.

@bmcdonnell-ionx

bmcdonnell-ionx Mar 8, 2018

Contributor

Good catch; my mistake - sorry! That's from unrelated work, which was not meant to be published.

I added a 4th commit, to undo the bad part from the 3rd commit. Should I squash the 4th into the 3rd?

@0xc0170 0xc0170 added needs: work and removed ready for merge labels Mar 8, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 9, 2018

/morph build

@0xc0170

0xc0170 approved these changes Mar 9, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Mar 9, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 9, 2018

Build : SUCCESS

Build number : 1398
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6149/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Mar 9, 2018

/morph mbed2-build

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Mar 15, 2018

Hi

We reviewed the changed files , we should not change 3rd party code

ST internal ticket to correct typos is opened.

Thx

@cmonr cmonr merged commit 9cac3b2 into ARMmbed:master Mar 15, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment