New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODIN MTB LEDs Fix #6193

Merged
merged 1 commit into from Feb 27, 2018

Conversation

Projects
None yet
5 participants
@ashok-rao
Contributor

ashok-rao commented Feb 23, 2018

Description

Clean up of Pin names for ODIN MTB. Required to build examples from online compiler.

Pull request type

  • Fix
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 26, 2018

@ARMmbed/team-ublox Please review

LED1 = LED_RED,
LED2 = LED_GREEN,
LED3 = LED_BLUE,

This comment has been minimized.

@0xc0170

0xc0170 Feb 26, 2018

Member

LED4 not needed? I recall some tests required LED1-4. I can not locate those tests (my searching fails), but most of the platforms defines LED1-4.

This comment has been minimized.

@ashok-rao

ashok-rao Feb 26, 2018

Contributor

@0xc0170 , I think LED1, LED2 are mandatory for the tests.. not sure about LED3 & LED4..
@cmonr .. IIRC, you added an LED2 in one of my other PR's for the tests as mandatory.. are LED3 and LED4 also mandatory?

This comment has been minimized.

@0xc0170

0xc0170 Feb 26, 2018

Member

@cmonr .. IIRC, you added an LED2 in one of my other PR's for the tests as mandatory.. are LED3 and LED4 also mandatory?

I assume not (can't find a reference with this requirement at the moment), wanted to be certain as it was previously LED up to 7, now we reducing to 3.

This comment has been minimized.

@cmonr

cmonr Feb 26, 2018

Contributor

At the moment, only LED1 and LED2 are manditory for the tests to run (which now that I'm thinking about it, that should probaly be a bug). All other LED definitions are not necessary.

This comment has been minimized.

@ashok-rao

ashok-rao Feb 27, 2018

Contributor

Hmm, this maybe something to consider for future. @cmonr can you point us to the location(s) where the LED's are used for the tests..My search yielded nothing..

@andreaslarssonublox

This comment has been minimized.

Contributor

andreaslarssonublox commented Feb 26, 2018

I have no ODIN MTB to check the LEDs with but otherwise I think it looks OK.

@cmonr

cmonr approved these changes Feb 26, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 26, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 26, 2018

Build : SUCCESS

Build number : 1263
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6193/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 27, 2018

==========STDERR==========
Eclipse:
An error has occurred. See the log file
/tmp/tmpIm79fN/.metadata/.log.

Eclipse, you and I need to have a word...

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: review labels Feb 27, 2018

@cmonr cmonr merged commit 815c6fb into ARMmbed:master Feb 27, 2018

17 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs/ Local docs testing has passed
Details
travis-ci/events/ Local events testing has passed
Details
travis-ci/littlefs/ Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL/ Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM/ Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC/ Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON/ Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP/ Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS/ Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM/ Local mbed2-STM testing has passed
Details
@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Feb 27, 2018

Thanks @cmonr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment