New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max32625mbed #6202

Merged
merged 6 commits into from Mar 7, 2018

Conversation

Projects
None yet
6 participants
@khariya
Contributor

khariya commented Feb 24, 2018

MAX32625: Fix serial interrupts and I2C master; Improve SPI block write, us ticker performance, ADC functionality

Description

Fix problems with missing serial objects for interrupts.
Remove automatic stop signaling after read transaction to allow repeated start after read.
Improve SPI block write by replacing byte write loop with hardware assisted block transaction.
Improve performance of us ticker.
Increase analog input range by 2x.

Tested all supported toolchains with MAX32625MBED.

Pull request type

  • Fix
  • Refactor
  • New Target
  • Feature

khariya added some commits Feb 2, 2018

Fix missing serial object for interrupts
Save serial objects when setting interrupt requests.
Improve uart interrupt handler.
Improve SPI block write
Replace looping construct with actual block writes.
Improve us ticker performance
Improves accuracy during heavy work load.
Enable ADC scaling and enable internal channels
Increases input range by 2x(now, 0-2.4v)
Remove automatic I2C stop after each read
Automatic stop prevents sending repeated start.
}
}
__enable_irq();

This comment has been minimized.

@0xc0170

0xc0170 Feb 26, 2018

Member

can you replace these with critical section enter/exit?

@0xc0170 0xc0170 added needs: work and removed needs: review labels Feb 26, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 26, 2018

@khariya Thanks for the fixes, they look good. Just one request regarding using critical section.

PR update addressed comment.

@cmonr

cmonr approved these changes Feb 27, 2018

Nice. I like all of the small changes.

In the future, it would help us if the larger bug fixes could be split into their own PR (referring to the SPI write API update)

@cmonr cmonr added needs: CI and removed needs: work labels Feb 27, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 27, 2018

/morph build

1 similar comment
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 27, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 27, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Feb 27, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 27, 2018

Build : SUCCESS

Build number : 1278
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6202/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 27, 2018

Using this build failure to debug current CI issues. Will kick off rebuild once stable again.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Feb 28, 2018

@cmonr can this one be kicked off again ?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 28, 2018

Kick.

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 1, 2018

/morph build

2 similar comments
@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 5, 2018

/morph build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 5, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 5, 2018

Build : SUCCESS

Build number : 1340
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6202/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Mar 6, 2018

/morph mbed2-build

@cmonr cmonr merged commit 2e69ddd into ARMmbed:master Mar 7, 2018

17 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs/ Local docs testing has passed
Details
travis-ci/events/ Local events testing has passed
Details
travis-ci/littlefs/ Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL/ Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM/ Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC/ Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON/ Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP/ Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-SILICON_LABS/ Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM/ Local mbed2-STM testing has passed
Details

@khariya khariya deleted the maximmbed:fix-max32625mbed branch Mar 7, 2018

@khariya khariya restored the maximmbed:fix-max32625mbed branch Mar 7, 2018

@khariya khariya deleted the maximmbed:fix-max32625mbed branch Mar 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment