New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve invalid configuration error messages #6240

Merged
merged 1 commit into from Mar 1, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Feb 28, 2018

old

[ERROR] OrderedDict([(u'help', u'Address of the active application firmware in flash'), (u'value', u'POST_APPLICATION_ADDR'), (u'required', 1)]) is not valid under any of the given schemas,OrderedDict([(u'help', u'Flash sector address for SOTP sector 1'), (u'macro_name', u'PAL_INTERNAL_FLASH_SECTION_1_ADDRESS'), (u'value', [])]) is not valid under any of the given schemas
[ERROR] 1 is not of type u'string'

new

[ERROR] in ./mbed_app.json element config.application-start-address.required: 1 is not of type u'boolean'; in ./mbed_app.json element config.sotp-section-1-address.value: [] is not of type u'integer', u'string', u'boolean', u'null'                                                  
[ERROR] in ./tools/mbed_lib.json element name: 1 is not of type u'string'

bug fix/ui improvement?

@marcuschangarm

@theotherjimmy theotherjimmy changed the title from /home/jimmy/pr-message.md to Add BL parameter definitions as new document Improve invalid configuration error messages Feb 28, 2018

@theotherjimmy theotherjimmy changed the title from Add BL parameter definitions as new document Improve invalid configuration error messages to Improve invalid configuration error messages Feb 28, 2018

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:better-config-errors branch from 7b7fa6f to 477b947 Feb 28, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Feb 28, 2018

@cmonr Verified working with app and lib config. Could you review?

@cmonr cmonr self-requested a review Feb 28, 2018

@cmonr cmonr added the needs: review label Feb 28, 2018

@cmonr cmonr requested a review from marcuschangarm Feb 28, 2018

@cmonr

cmonr approved these changes Feb 28, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Feb 28, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Feb 28, 2018

Build : SUCCESS

Build number : 1308
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6240/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: review labels Mar 1, 2018

@adbridge adbridge merged commit f624802 into ARMmbed:master Mar 1, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment