New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macro definition of iodefine_typedef for RZ_A1H #6288

Merged
merged 1 commit into from Mar 15, 2018

Conversation

Projects
None yet
4 participants
@TomoYamanaka
Contributor

TomoYamanaka commented Mar 7, 2018

Description

Regarding RZ_A1H, Since I removed the macro definition accidentally in iodefine_typedef, I fixed the lack of it.

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change
@@ -55,6 +55,11 @@ typedef enum iodefine_byte_select_t
{
R_IO_L = 0, R_IO_H = 1,
R_IO_LL= 0, R_IO_LH = 1, R_IO_HL = 2, R_IO_HH = 3
#if(1) /* mbed */

This comment has been minimized.

@0xc0170

0xc0170 Mar 7, 2018

Member

why is this #if (1) needed , can we remove it?

Fix macro definition of iodefine_typedef for RZ_A1H
Regarding RZ_A1H, Since I removed the macro definition accidentally in iodefine_typedef, I fixed the lack of it.

@TomoYamanaka TomoYamanaka force-pushed the TomoYamanaka:master branch from ab7e01f to 3183d21 Mar 7, 2018

@TomoYamanaka

This comment has been minimized.

Contributor

TomoYamanaka commented Mar 7, 2018

why is this #if (1) needed , can we remove it?

I modified.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 7, 2018

Thanks looks good, will approve.

One note about PR type, can you please leave it in the first message and fill it accordingly ?

In this case:

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

I edited the first one now

@0xc0170

0xc0170 approved these changes Mar 7, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 7, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 7, 2018

Build : SUCCESS

Build number : 1379
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6288/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@TomoYamanaka

This comment has been minimized.

Contributor

TomoYamanaka commented Mar 7, 2018

@0xc0170
Thank you for your advice. I'll be careful from now on.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 8, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 9, 2018

@cmonr cmonr merged commit 69bc68d into ARMmbed:master Mar 15, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B (+0.00%)
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment