Peek API to view data of buffer without popping #6309
Conversation
|
I believe this falls under "feature" Does the Circular Buffer have tests? Could we add a test covering this function? |
| * @param data Data to be peeked from the buffer | ||
| * @return True if the buffer is not empty and data contains a transaction, false otherwise | ||
| */ | ||
| bool peek(T& data) const { |
There was a problem hiding this comment.
Hmm, does data need to be const if peek is a const member function?
There was a problem hiding this comment.
const member function is not allowed to modify the object elements, which is not done in case of this API. But we are passing data as return value hence it cannot be const.
There was a problem hiding this comment.
That would be an issue if it was a const reference (T& const data). But since it's a reference-to-const (const T& data), it should be fine.
Does this compile as is with a const CircularBuffer?
There was a problem hiding this comment.
Not all members of CircularBuffer are const, without this API also it won't compile as const CircularBuffer.
(const T& data) in case of template class says value of data variable cannot be modified in the function. We are passing the data value, hence it cannot be const. I tried compilation with const and it failed.
There was a problem hiding this comment.
Oh, that's annoying if there's a similar issue in other functions.
const T& data can be assigned with issue.
|
/morph build |
Build : SUCCESSBuild number : 1503 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 1146 |
Test : SUCCESSBuild number : 1286 |
|
/morph export-build |
Exporter Build : SUCCESSBuild number : 1157 |
Description
Added
peekAPI to view data of CircularBuffer without popping.Pull request type