-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
armcc - remove fromelf output before regenerating one #6344
Conversation
@ARMmbed/team-realtek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excerpts from prior PRs that proposed the same change:
Typically when there are multiple LRs and building creates a directory rather than a binary it indicates something is wrong in the scatter file. Adding this change may mask scatter file errors. Rather than having an obvious error at compile time, a binary will be created that does not work.
It looks like the LPC4088_DM's post build hook makes use of multiple regions being created if the binary is big enough. It does this by manually combining the regions with little padding (up to 512K). With this PR padding is done automatically, but rather than 512K it pads the entire address space from LR_IROM1 to LR_IROM which is ~640MB.
How do you plan on correcting that behavior for the LPC4088_DM? How do you plan on making this change in a way that is backwards compatible? Could using a .hex
file be a viable workaround?
Hi @tung7970 could you please help comment on @0xc0170 @theotherjimmy questions? Thanks. |
Fix armcc recompile errors during elf2bin stage. Errors shown as follows: Elf2Bin: mbed-os-example-wifi Error: Q0147E: Failed to create Directory .\BUILD\REALTEK_RTL8195AM\ARM\mbed-os-example-wifi.bin\IMAGE2_TABLE: File exists Finished: 0 information, 0 warning and 1 error messages. [ERROR] Error: Q0147E: Failed to create Directory .\BUILD\REALTEK_RTL8195AM\ARM\mbed-os-example-wifi.bin\IMAGE2_TABLE: File exists Finished: 0 information, 0 warning and 1 error messages. Signed-off-by: Tony Wu <tonywu@realtek.com>
@0xc0170 So far, only ARMCC creates directory if there are multiple load regions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
/morph build |
Build : SUCCESSBuild number : 1496 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1140 |
Test : SUCCESSBuild number : 1279 |
Description
Fix armcc recompile errors during elf2bin stage. Errors shown as follows:
Elf2Bin: mbed-os-example-wifi
Error: Q0147E: Failed to create Directory .\BUILD\REALTEK_RTL8195AM\ARM\mbed-os-example-wifi.bin\IMAGE2_TABLE: File exists
Finished: 0 information, 0 warning and 1 error messages.
[ERROR] Error: Q0147E: Failed to create Directory .\BUILD\REALTEK_RTL8195AM\ARM\mbed-os-example-wifi.bin\IMAGE2_TABLE: File exists
Finished: 0 information, 0 warning and 1 error messages.
Fix issue #6306
Pull request type