New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dir seek fixed - dptr was not updated before checking #6363

Merged
merged 1 commit into from Mar 20, 2018

Conversation

Projects
None yet
6 participants
@deepikabhavnani
Contributor

deepikabhavnani commented Mar 14, 2018

Description

Fix for: ARMmbed/sd-driver#84

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

@geky @marcuschangarm

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:seek_fix branch from f953042 to 351aaa8 Mar 14, 2018

@marcuschangarm

This comment has been minimized.

Contributor

marcuschangarm commented Mar 14, 2018

Can confirm this fixes ARMmbed/sd-driver#84.

@geky

geky approved these changes Mar 14, 2018

@deepikabhavnani deepikabhavnani referenced this pull request Mar 14, 2018

Merged

CRC support added #75

@0xc0170 0xc0170 added the needs: CI label Mar 15, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 15, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 15, 2018

Build : SUCCESS

Build number : 1453
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6363/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 15, 2018

Error: L6200E: Symbol __asm___19_stm32f4xx_hal_can_c____REV16 multiply defined (by mbed-os/targets/TARGET_STM/TARGET_STM32F4/device/stm32f4xx_hal_dfsdm.o and mbed-os/targets/TARGET_STM/TARGET_STM32F4/device/stm32f4xx_hal_can.o).
Error: L6200E: Symbol __asm___19_stm32f4xx_hal_can_c____REVSH multiply defined (by mbed-os/targets/TARGET_STM/TARGET_STM32F4/device/stm32f4xx_hal_dfsdm.o and mbed-os/targets/TARGET_STM/TARGET_STM32F4/device/stm32f4xx_hal_can.o).
Error: L6200E: Symbol __asm___19_stm32f4xx_hal_can_c____RRX multiply defined (by mbed-os/targets/TARGET_STM/TARGET_STM32F4/device/stm32f4xx_hal_dfsdm.o and mbed-os/targets/TARGET_STM/TARGET_STM32F4/device/stm32f4xx_hal_can.o).
Finished: 0 information, 0 warning and 3 error messages.

Restarting since we've noticed this is an intermittent issue.
/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 19, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 20, 2018

@cmonr cmonr merged commit a3d8c8f into ARMmbed:master Mar 20, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B (+0.00%)
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:seek_fix branch Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment