New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deep sleep implementation #6468

Merged
merged 3 commits into from Apr 17, 2018

Conversation

Projects
None yet
8 participants
@mmahadevan108
Contributor

mmahadevan108 commented Mar 27, 2018

Fixes the Deep sleep implementation for the MCUXpresso SoC's. This is based on testing using the latest sleep manager that invokes deepsleep mode in the idle loop

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Mar 27, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 27, 2018

@bulislaw

This comment has been minimized.

Member

bulislaw commented Mar 27, 2018

Why are we changing so many Flash files?

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Mar 27, 2018

This commit is updating the SDK flash drivers on certain platforms to use the API's available in the new drivers that are required for deep sleep entry and exit.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 27, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 27, 2018

@mmahadevan108 mmahadevan108 dismissed stale reviews from bulislaw and 0xc0170 via 1e40702 Mar 27, 2018

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Fix_DeepSleep_Implementation branch from 41009c0 to 1e40702 Mar 27, 2018

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Mar 27, 2018

Updated LPC546XX to address build issue seen.

#define LPC_CLOCK_INTERNAL_IRC BOARD_BootClockFRO12M
#define LPC_CLOCK_RUN BOARD_BootClockFROHF48M
#define LPC_CLOCK_INTERNAL_IRC BOARD_BootClockFRO12M()
#define LPC_CLOCK_RUN ((SYSCON->DEVICE_ID0 == 0xFFF54628) ? \

This comment has been minimized.

@cmonr

cmonr Mar 28, 2018

Contributor

This feels very strange to do. What's the reason that a different clock sequence/function is required for a single part?

This comment has been minimized.

@mmahadevan108

mmahadevan108 Mar 28, 2018

Contributor

This is to identify a LPC54628 part in the LPC546XX family. LPC54628 which is capable of running at higher speeds.

@cmonr cmonr added needs: review and removed needs: CI labels Mar 28, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 28, 2018

@bulislaw @0xc0170 Requesting a re-review.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 28, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 28, 2018

Build : SUCCESS

Build number : 1606
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6468/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Mar 28, 2018

Test : FAILURE
Build number : 1392
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6468/1392

This failure is because of USB devices going offline. as the pipeline is deep, not re-triggering.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 3, 2018

/morph test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Fix_DeepSleep_Implementation branch from 13e6d2a to 9a1e749 Apr 10, 2018

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Apr 10, 2018

I have rebased and updated this PR.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 10, 2018

Going to restart build since rebase caused status to be lost. Still on hold pending pr-head resolution.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 10, 2018

Build : SUCCESS

Build number : 1716
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6468/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 11, 2018

jenkins CI still failing. We are investigating other options, github has not yet fixed the issue 😢

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 11, 2018

...huh. Unless I'm mistaken, it looks like this singular test finished too quickly.

[1523474064.61][HTST][INF] DUT greentea-client version: 1.3.0 [1523474064.61][CONN][INF] found KV pair in stream: {{__timeout;30}}, queued... [1523474064.61][HTST][INF] setting timeout to: 30 sec [1523474064.61][CONN][INF] found KV pair in stream: {{__host_test_name;echo}}, queued... [1523474064.61][CONN][INF] found KV pair in stream: {{__testcase_count;1}}, queued... [1523474064.61][HTST][INF] host test class: ''
[1523474064.61][HTST][INF] host test setup() call...
[1523474064.61][HTST][INF] CALLBACKs updated
[1523474064.61][HTST][INF] host test detected: echo
[1523474064.62][CONN][RXD] >>> Running 1 test cases...
[1523474064.62][CONN][RXD] 
[1523474064.62][CONN][INF] found KV pair in stream: {{__testcase_name;Echo server: x16}}, queued...
[1523474064.71][CONN][RXD] >>> Running case #1: 'Echo server: x16'...
[1523474064.71][CONN][INF] found KV pair in stream: {{__testcase_start;Echo server: x16}}, queued...
[1523474064.71][CONN][INF] found KV pair in stream: {{echo_count;16}}, queued...
[1523474064.71][GLRM][TXD] {{echo_count;16}}
[1523474064.71][GLRM][TXD] {{echo;b7839f98-f198-4889-a1c6-6a8d9e6d170e}}
[1523474094.74][HTST][INF] test suite run finished after 30.13 sec...
[1523474094.74][CONN][INF] received special event '__host_test_finished' value='True', finishing
[1523474094.74][urllib3.connectionpool]Starting new HTTP connection (1): iron-gatekeeper
[1523474094.79][urllib3.connectionpool]http://iron-gatekeeper:8000 "PUT /resource/0602000041114e45001a3003b60f0012a6e1000097969900/disconnect HTTP/1.1" 200 2
[1523474094.79][urllib3.connectionpool]Starting new HTTP connection (1): iron-gatekeeper
[1523474097.97][urllib3.connectionpool]http://iron-gatekeeper:8000 "PUT /resource/0602000041114e45001a3003b60f0012a6e1000097969900/release HTTP/1.1" 200 66
[1523474097.97][HTST][INF] CONN exited with code: 0
[1523474097.97][HTST][INF] No events in queue
[1523474097.97][HTST][INF] stopped consuming events
[1523474097.97][HTST][INF] host test result(): False
[1523474097.97][HTST][WRN] missing __exit event from DUT
[1523474097.97][HTST][WRN] missing __exit_event_queue event from host test
[1523474097.97][HTST][INF] calling blocking teardown()
[1523474097.97][HTST][INF] teardown() finished
[1523474097.97][HTST][INF] {{result;failure}}
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 12, 2018

/morph test

@mbed-ci

This comment has been minimized.

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Apr 16, 2018

Can you let me know the reason failure.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 16, 2018

@mmahadevan108 The morph test failure and cause for restart appears to be due to a test that is completing too fast. We're monitoring that particular test for right now.

As for the pr-head failure, about a week ago, we discovered an issue with how that particular job pulls references from GitHub and GitHub confirmed that they were getting other complaints as well. Once this is solved, we'll rerun all pr-head jobs that are currently blocking ~10 PRs.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 17, 2018

@cmonr cmonr merged commit 7489401 into ARMmbed:master Apr 17, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9933 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 17, 2018

@mmahadevan108 mmahadevan108 deleted the NXPmicro:Fix_DeepSleep_Implementation branch Apr 19, 2018

0xc0170 added a commit to 0xc0170/mbed-os that referenced this pull request Apr 23, 2018

KL27Z: Flash protection macro addition
PR ARMmbed#6468 updated flash driver, but not for KL27Z target (another CPU type).
It is missing and leads to build failure. This fixes it.

0xc0170 added a commit to 0xc0170/mbed-os that referenced this pull request Apr 24, 2018

KL27Z: Flash protection macro addition
PR ARMmbed#6468 updated flash driver, but not for KL27Z target (another CPU type).
It is missing and leads to build failure. This fixes it.
@adbridge

This comment has been minimized.

Contributor

adbridge commented Apr 25, 2018

@mmahadevan108 For future reference could we please have more details in the PR body. It should really contain the following:

  1. Description of the actual problem
  2. Description of the fix
  3. How this was tested
  4. Any other dependencies related to the PR

Thanks :)

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Apr 25, 2018

Sure

davidsaada added a commit to davidsaada/mbed-os that referenced this pull request May 8, 2018

KL27Z: Flash protection macro addition
PR ARMmbed#6468 updated flash driver, but not for KL27Z target (another CPU type).
It is missing and leads to build failure. This fixes it.

davidsaada added a commit to davidsaada/mbed-os that referenced this pull request May 8, 2018

KL27Z: Flash protection macro addition
PR ARMmbed#6468 updated flash driver, but not for KL27Z target (another CPU type).
It is missing and leads to build failure. This fixes it.

kegilbert added a commit to kegilbert/mbed-os that referenced this pull request May 17, 2018

KL27Z: Flash protection macro addition
PR ARMmbed#6468 updated flash driver, but not for KL27Z target (another CPU type).
It is missing and leads to build failure. This fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment