New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize the size of uvision include paths #6487

Merged
merged 2 commits into from Mar 28, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Mar 27, 2018

Description

The size of uvision include paths can break the exporter with very large
projects. Some nordic devices are very large projects by themselves.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr

cmonr approved these changes Mar 27, 2018

Tested on local machine.

Build fails with #6447. Updating with this PR branch completes build.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 27, 2018

/morph build

@cmonr cmonr added the needs: CI label Mar 27, 2018

@cmonr cmonr referenced this pull request Mar 27, 2018

Merged

Update HID classes #6447

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 27, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 27, 2018

Build : SUCCESS

Build number : 1599
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6487/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 28, 2018

ಠ_ಠ

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 28, 2018

@0xc0170

Approve to unblock PR.

But still we might face this issue in the future . How big buffer is in uvision? Can it be fixed there ? What other options we have once we have this problem again ?

@0xc0170 0xc0170 merged commit 25a2d15 into ARMmbed:master Mar 28, 2018

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9563 cycles (+644 cycles)
Details
travis-ci/littlefs Passed, code size is 10092B
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment