New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial SP for new Silicon Labs targets on ARMCC #6488

Merged
merged 1 commit into from Mar 29, 2018

Conversation

Projects
None yet
7 participants
@stevew817
Contributor

stevew817 commented Mar 27, 2018

Description

EFR32MG1, EFR32MG12 and EFM32PG12 didn't have a fixed ARMCC linker script yet.

Pull request type

[ X ] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Set up the ISR stack pointer in the right location on ARMCC
EFR32MG1, EFR32MG12 and EFM32PG12 didn't have a fixed ARMCC linker script yet.
@stevew817

This comment has been minimized.

Contributor

stevew817 commented Mar 27, 2018

@cmonr

cmonr approved these changes Mar 28, 2018

👍

@cmonr cmonr requested review from screamerbg and ashok-rao Mar 28, 2018

@cmonr cmonr added the needs: review label Mar 28, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 28, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 28, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 28, 2018

Build : SUCCESS

Build number : 1608
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6488/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@ashok-rao

LGTM @stevew817 . Thanks!

@screamerbg

This comment has been minimized.

Member

screamerbg commented Mar 28, 2018

LGTM!

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 4797b53 into ARMmbed:master Mar 29, 2018

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8918 cycles
Details
travis-ci/littlefs Passed, code size is 10092B
Details
travis-ci/tools Local tools testing has passed
Details
@adbridge

This comment has been minimized.

Contributor

adbridge commented Apr 11, 2018

@stevew817 For future reference please do not remove the PR proforma . Just add your description in the section provided and make sure you select the PR type in the list (by just adding a X to the relevant type). Also the description should better explain what the PR is doing. Thanks.
I have added back the proforma to show you how it should look.

@mbed-ci

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment