New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAX32620C] Add new target #6503

Merged
merged 2 commits into from Apr 9, 2018

Conversation

Projects
None yet
5 participants
@khariya
Contributor

khariya commented Mar 28, 2018

[MAX32620C] Add new target

Description

Add new target MAX32620C with MAX32620FTHR platform.

Tested all supported toolchains with MAX32620FTHR.

Pull request type

[ ] Fix
[ ] Refactor
[X] New target
[ ] Feature
[ ] Breaking change

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 3, 2018

@khariya, could you share the test results for all three compilers with this new target?

Also, please take a look at the Travis CI docs failure.

@cmonr cmonr added the needs: work label Apr 3, 2018

@0xc0170

Just one question regarding deepsleep, the rest looks good to me

// Low-power stop mode
void hal_deepsleep(void)
{
hal_sleep();

This comment has been minimized.

@0xc0170

0xc0170 Apr 3, 2018

Member

Why deep sleep = sleep ?

This comment has been minimized.

@jessexm

jessexm Apr 4, 2018

Contributor

Current DAPLink implementation unable to wake device from deep sleep (Maxim LP1) for reprogramming.

This comment has been minimized.

@0xc0170

0xc0170 Apr 5, 2018

Member

That is a pity, is this limitation captured anywhere? If you look at feature hal specs for sleep (there's feature branch for it), this will cause a failure there with this new specifications.

Will this be fixed later?

This comment has been minimized.

@jessexm

jessexm Apr 6, 2018

Contributor

The deep sleep feature is implemented but not released. We are working to add "connect under reset" functionality to the DAPLink drag and drop interface.

@khariya

This comment has been minimized.

Contributor

khariya commented Apr 4, 2018

@0xc0170

0xc0170 approved these changes Apr 5, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Apr 5, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 5, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 5, 2018

Build : SUCCESS

Build number : 1665
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6503/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 6, 2018

/morph mbed2-build

@0xc0170 0xc0170 merged commit 1b2f63a into ARMmbed:master Apr 9, 2018

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9569 cycles (+274 cycles)
Details
travis-ci/littlefs Passed, code size is 10092B
Details
travis-ci/tools Local tools testing has passed
Details

@khariya khariya deleted the maximmbed:add-platform-MAX32620C branch Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment