New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new target USI WM-BN-BM-22 #6511

Merged
merged 2 commits into from Apr 9, 2018

Conversation

Projects
None yet
4 participants
@ashok-rao
Contributor

ashok-rao commented Mar 29, 2018

Description

Adding USI WM-BN-BM22 (MTB) as a new target.

Pull request type

[ ] Fix
[ ] Refactor
[X] New target
[ ] Feature
[ ] Breaking change

GT logs are attached below. From the logs:

  1. RTC is timing out on GCC and IAR and
  2. There are lp_timer / lp_ticker timing out on ARMCC similar to that reported here: #6423 (comment) . Please note that these 2 modules are using the exact same CPU.

GT_Log_ARMCC.txt
GT_Log_GCC.txt
GT_Log_IAR.txt

@0xc0170 @cmonr .. could you please review? Thanks.

ashok-rao added some commits Mar 29, 2018

@0xc0170

0xc0170 approved these changes Apr 3, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 3, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 3, 2018

Build : SUCCESS

Build number : 1643
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6511/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 3, 2018

Looking at the test results and issues there. Should lp ticker and rtc be disabled as part of this addition and reenabled once fixed?

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Apr 3, 2018

Thanks @0xc0170 ..this may have to fixed from the MCU implementation side for both this and the #6423 as both use the same MCU.. I can remove those 2 features from targets.json for this module.. and need to add back once fixed..
I'll push the changes to targets.json soon.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 3, 2018

@ashok-rao If this is affecting some other MCU, please create a new PR for this disabling (this would stay as it is and would just be rebased to include the inclusion).

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 6, 2018

@ashok-rao Is this ready? I haven't seen the PR disabling features that are failing (report with failures) ?

@0xc0170 0xc0170 changed the title from Adding USI WM-BN-BM-22 as a new target to Add new target USI WM-BN-BM-22 Apr 9, 2018

@0xc0170 0xc0170 merged commit a3faf58 into ARMmbed:master Apr 9, 2018

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9016 cycles
Details
travis-ci/littlefs Passed, code size is 10092B
Details
travis-ci/tools Local tools testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 9, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 9, 2018

@ashok-rao Lets discuss the issues you saw with the parent target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment