New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Mbed 5 support check so that it affects the exporters #6512

Merged
merged 1 commit into from Apr 3, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Mar 29, 2018

Description

A recent PR of mine stopped the exporters from using the build_api's
unified scan_resourcses method. Instead, I moved the supported check to
the earliest location that we have this informaiton: the end of the
config object's load_resources method.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 3, 2018

I suppose this code reactor allows the export command to fail much sooner in the export process?

@cmonr

cmonr approved these changes Apr 3, 2018

@cmonr cmonr added the needs: CI label Apr 3, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 3, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 3, 2018

Build : SUCCESS

Build number : 1637
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6512/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

0xc0170 approved these changes Apr 3, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 3, 2018

@cmonr Can you review the latest test result? It's related to the patch you sent earlier, and it's on master branch?

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 3, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 3, 2018

@cmonr Yes, it failes before it get to the exporter. It may have even got to the compiler in the IDE before 😱

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 3, 2018

@0xc0170 Am doing
@theotherjimmy xD

@cmonr cmonr merged commit 4a5ac14 into ARMmbed:master Apr 3, 2018

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9595 cycles (+16 cycles)
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment