New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct armc6 detection logic for STM32L4 #6553

Merged
merged 1 commit into from Apr 9, 2018

Conversation

Projects
None yet
4 participants
@theotherjimmy
Contributor

theotherjimmy commented Apr 5, 2018

Description

The following targets did not compile tests before this change:

  • NUCLEO_L476RG
  • NUCLEO_L486RG

They now compile tests

Pull request type

[✓] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@theotherjimmy theotherjimmy changed the title from Correct armc6 detection logic to Correct armc6 detection logic for STM32L4 Apr 5, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 5, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 6, 2018

Fixes #6548

Thanks @theotherjimmy

@0xc0170

0xc0170 approved these changes Apr 6, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 6, 2018

/morph build

@0xc0170 0xc0170 added the needs: CI label Apr 6, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 6, 2018

Build : SUCCESS

Build number : 1670
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6553/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 6, 2018

@adustm Can you review? looks fine to me

@adustm

adustm approved these changes Apr 9, 2018

@0xc0170 0xc0170 merged commit 8b2eb20 into ARMmbed:master Apr 9, 2018

11 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10432 cycles (+1137 cycles)
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment