New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: add detach from the network #6570

Merged
merged 2 commits into from Apr 17, 2018

Conversation

Projects
None yet
5 participants
@jarvte
Contributor

jarvte commented Apr 9, 2018

Description

Added detach from cellular network.

@AriParkkila please review.

Internal ref to defect: IOTCELL-758

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

@@ -665,7 +665,7 @@ bool AT_CellularNetwork::has_registration(RegistrationType reg_type)
return true;
}
nsapi_error_t AT_CellularNetwork::set_attach(int timeout)
nsapi_error_t AT_CellularNetwork::set_attach(int /*timeout*/)

This comment has been minimized.

@AriParkkila

AriParkkila Apr 9, 2018

Contributor

I guess that "timeout" is and will not be used, so could add deprecated notice?

This comment has been minimized.

@jarvte

jarvte Apr 9, 2018

Contributor

good point, added deprecation

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 10, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 10, 2018

Build : SUCCESS

Build number : 1698
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6570/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 10, 2018

Interesting. Sync failed with the MAX32630.

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Apr 11, 2018

@jarvte jarvte force-pushed the jarvte:add_cellular_detach branch from 5b0e955 to 0b5fae3 Apr 12, 2018

@0xc0170 0xc0170 added needs: CI and removed ready for merge labels Apr 12, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 12, 2018

Recently rebased? Restarting CI

/morph build

@jarvte

This comment has been minimized.

Contributor

jarvte commented Apr 12, 2018

Yes, conflicts did appear so I had to rebase and fix.

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 12, 2018

Build : SUCCESS

Build number : 1728
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6570/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 13, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@jarvte

This comment has been minimized.

Contributor

jarvte commented Apr 17, 2018

@0xc0170 github issue again? Should I rebase master?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 17, 2018

@0xc0170 github issue again? Should I rebase master?

Restarted it, should be fixed, waiting for it to complete

@0xc0170 0xc0170 changed the title from Cellular: added detach from the network. to Cellular: add detach from the network Apr 17, 2018

@0xc0170 0xc0170 removed the needs: CI label Apr 17, 2018

@cmonr cmonr merged commit 259f9fd into ARMmbed:master Apr 17, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9059 cycles (+106 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 17, 2018

@jarvte jarvte deleted the jarvte:add_cellular_detach branch Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment