New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: add future #6602

Merged
merged 1 commit into from Apr 23, 2018

Conversation

Projects
None yet
4 participants
@0xc0170
Member

0xc0170 commented Apr 11, 2018

Description

SHA 14255ca introduced the lines that are reported to be breaking.
future module in requirements fixes it

Reference: https://pypi.python.org/pypi/future

Fixes #6489

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested review from theotherjimmy and screamerbg Apr 11, 2018

@theotherjimmy

Please add a version.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 11, 2018

Please add a version.

I was wondering about that one (seen some modules there that did not have any). What version range would be in this case ? The latest one is 0.16.0

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 11, 2018

What version range would be in this case ? The latest one is 0.16.0

You could try older versions, or you could just require 0.16.0. Up to you.

requirements: add future
SHA 14255ca introduced the lines that are reported to be breaking.
future module in requirements fixes it

Reference: https://pypi.python.org/pypi/future

Fixes #6489

@0xc0170 0xc0170 force-pushed the 0xc0170:fix_req_future branch from dd618c8 to f316373 Apr 13, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 13, 2018

Version added

@cmonr

cmonr approved these changes Apr 17, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 17, 2018

/morph build

Commit updated. Version added.

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 17, 2018

Build : SUCCESS

Build number : 1764
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6602/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 11b6a4e into ARMmbed:master Apr 23, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9083 cycles (+123 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment