Skip to content

Cellular: fixed athandler unit tests. #6620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Apr 12, 2018

Description

Fixed ATHandler unit tests. No code changes.

Internal ref to defect: IOTCELL-777

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Copy link

@AnttiKauppila AnttiKauppila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like magic number 20, but if we create more tests needing different values, we can stub it then.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 13, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 13, 2018

Build : SUCCESS

Build number : 1741
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6620/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 13, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 13, 2018

@cmonr
Copy link
Contributor

cmonr commented Apr 14, 2018

Interesting. Second occurance of Echo test failing with EV_COG_AD4050LZ board when compiled with IAR.

/morph test

@mbed-ci
Copy link

mbed-ci commented Apr 14, 2018

@cmonr cmonr merged commit 7188c8a into ARMmbed:master Apr 16, 2018
@jarvte jarvte deleted the cellular_fixing_at_unit_tests branch April 17, 2018 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants