New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: fixed athandler unit tests. #6620

Merged
merged 1 commit into from Apr 16, 2018

Conversation

Projects
None yet
5 participants
@jarvte
Contributor

jarvte commented Apr 12, 2018

Description

Fixed ATHandler unit tests. No code changes.

Internal ref to defect: IOTCELL-777

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from AnttiKauppila Apr 12, 2018

@AnttiKauppila

I don't like magic number 20, but if we create more tests needing different values, we can stub it then.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 13, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 13, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 13, 2018

Build : SUCCESS

Build number : 1741
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6620/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 14, 2018

Interesting. Second occurance of Echo test failing with EV_COG_AD4050LZ board when compiled with IAR.

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 7188c8a into ARMmbed:master Apr 16, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9133 cycles (+180 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 16, 2018

@jarvte jarvte deleted the jarvte:cellular_fixing_at_unit_tests branch Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment