Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing carriage returns to fault handler #6654

Merged
merged 1 commit into from
May 7, 2018

Conversation

kjbracey
Copy link
Contributor

Description

Fault handler was outputting just LFs between lines, when standard
terminals require CR+LF, leading to messy output.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[X] Breaking change

Marked "breaking change" because it could conceivably trip up some automation relying on parsing fault handler output that expects odd formatting - it does change the output.

Seems unlikely though, as most normal output will be CR+LF terminated, either because apps do \r\n manually (yuck) or because platform.stdio-convert-newlines is turned on as it should be. So anything parsing general output will be expecting that.

Fault handler was outputting just LFs between lines, when standard
terminals require CR+LF, leading to messy output.
@adbridge
Copy link
Contributor

@SenRamakri we are still awaiting your review on this PR, could you please do so asap. Thanks.

Copy link
Contributor

@SenRamakri SenRamakri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, by the way, I'm in the process of refactoring this code as part of error handling. So this may get moved elsewhere.

@0xc0170
Copy link
Contributor

0xc0170 commented May 3, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 3, 2018

Build : SUCCESS

Build number : 1906
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6654/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 3, 2018

@mbed-ci
Copy link

mbed-ci commented May 4, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented May 4, 2018

We will investigate the failure (not related here, noticed it in the last day)

/morph test

@mbed-ci
Copy link

mbed-ci commented May 4, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented May 7, 2018

Fix for the last test is now on master, restarting

/morph test

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

@cmonr cmonr merged commit 53aa1b0 into ARMmbed:master May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants