-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing carriage returns to fault handler #6654
Conversation
Fault handler was outputting just LFs between lines, when standard terminals require CR+LF, leading to messy output.
@SenRamakri we are still awaiting your review on this PR, could you please do so asap. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, by the way, I'm in the process of refactoring this code as part of error handling. So this may get moved elsewhere.
/morph build |
Build : SUCCESSBuild number : 1906 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1553 |
Test : FAILUREBuild number : 1724 |
We will investigate the failure (not related here, noticed it in the last day) /morph test |
Test : FAILUREBuild number : 1736 |
Fix for the last test is now on master, restarting /morph test |
Test : SUCCESSBuild number : 1747 |
Description
Fault handler was outputting just LFs between lines, when standard
terminals require CR+LF, leading to messy output.
Pull request type
[ ] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[X] Breaking change
Marked "breaking change" because it could conceivably trip up some automation relying on parsing fault handler output that expects odd formatting - it does change the output.
Seems unlikely though, as most normal output will be CR+LF terminated, either because apps do
\r\n
manually (yuck) or becauseplatform.stdio-convert-newlines
is turned on as it should be. So anything parsing general output will be expecting that.