New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing carriage returns to fault handler #6654

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
7 participants
@kjbracey-arm
Contributor

kjbracey-arm commented Apr 17, 2018

Description

Fault handler was outputting just LFs between lines, when standard
terminals require CR+LF, leading to messy output.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[X] Breaking change

Marked "breaking change" because it could conceivably trip up some automation relying on parsing fault handler output that expects odd formatting - it does change the output.

Seems unlikely though, as most normal output will be CR+LF terminated, either because apps do \r\n manually (yuck) or because platform.stdio-convert-newlines is turned on as it should be. So anything parsing general output will be expecting that.

@0xc0170 0xc0170 requested a review from SenRamakri Apr 17, 2018

Add missing carriage returns to fault handler
Fault handler was outputting just LFs between lines, when standard
terminals require CR+LF, leading to messy output.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:fault_cr branch from ca0ded1 to fc61b8a Apr 17, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Apr 30, 2018

@SenRamakri we are still awaiting your review on this PR, could you please do so asap. Thanks.

@SenRamakri

Looks good, by the way, I'm in the process of refactoring this code as part of error handling. So this may get moved elsewhere.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 3, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 3, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented May 3, 2018

Build : SUCCESS

Build number : 1906
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6654/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 4, 2018

We will investigate the failure (not related here, noticed it in the last day)

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 7, 2018

Fix for the last test is now on master, restarting

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 7, 2018

@cmonr cmonr merged commit 53aa1b0 into ARMmbed:master May 7, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9046 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment