New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SingletonPtr in Nanostack HAL #6663

Merged
merged 1 commit into from Apr 19, 2018

Conversation

Projects
None yet
5 participants
@kjbracey-arm
Contributor

kjbracey-arm commented Apr 18, 2018

Description

Avoid static data/code overhead when Nanostack HAL isn't in use.
Preparation for removal of FEATURE_COMMON_PAL.

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Use SingletonPtr in Nanostack HAL
Avoid static data/code overhead when Nanostack HAL isn't in use.
Preparation for removal of FEATURE_COMMON_PAL.
@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented Apr 18, 2018

@SeppoTakalo - maybe cherry-pick this into your thing

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 18, 2018

/morph build

@0xc0170 0xc0170 requested a review from SeppoTakalo Apr 18, 2018

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Apr 18, 2018

Cherry-picked this here: #6577

Tested with Mesh application against master(without this change), this PR and #6577
All seem to work.

@SeppoTakalo

Good.

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 18, 2018

Build : SUCCESS

Build number : 1781
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6663/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 18, 2018

cc @studavekar

/morph export-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 18, 2018

/morph uvisor-test

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 18, 2018

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 19, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit cbb1033 into ARMmbed:master Apr 19, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9773 cycles (+245 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@kjbracey-arm kjbracey-arm deleted the kjbracey-arm:nshal-static-removal branch Apr 19, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Apr 20, 2018

This has been added on top of #6627 which is targeted for 5.9

@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented Apr 20, 2018

Was marked as refactor, should not have been labelled for 5.8.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment