ADI: Enable bootloader for EV_COG_AD3029LZ and EV_COG_AD4050LZ #6690

li-ho · 2018-04-20T06:15:17Z

Description

Rework EV_COG_AD3029LZ linker scripts to support bootloader
Rework EV_COG_AD4050LZ linker scripts to support bootloader

Pull request type

- fix compiler warning message of flash_api.c - fix compiler warning message of startup_ADuCM4050.c - eliminate absolute address of ROM tables - add MBED_APP_START and MBED_APP_SIZE to linker scripts

- fix compiler warning message of flash_api.c - eliminate absolute address of ROM tables - add MBED_APP_START and MBED_APP_SIZE to linker scripts

0xc0170

@li-ho How was this tested? any tests to be shared for this addition?

li-ho · 2018-04-20T08:42:15Z

@0xc0170 They were tested with
https://github.com/armmbed/mbed-os-example-bootloader
and
https://github.com/armmbed/mbed-os-example-bootloader-blinky

"target.restrict_size": "0x20000" for both EV_COG_AD4050LZ and EV_COG_AD3029LZ

The following expansion add-on board:
https://wiki.analog.com/resources/eval/user-guides/ev-gear-expander1z
has the SD card slot, and is required for testing.

If ev-gear-expander1z is not available, mbed-os-example-bootloader-blinky.bin can run straightforwadly.

0xc0170 · 2018-04-20T09:35:39Z

/morph build

mbed-ci · 2018-04-20T10:04:54Z

Build : SUCCESS

Build number : 1812
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6690/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-04-20T12:27:17Z

Exporter Build : SUCCESS

Build number : 1458
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6690/

mbed-ci · 2018-04-20T12:28:04Z

Test : SUCCESS

Build number : 1620
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6690/1620

0xc0170 · 2018-05-23T09:58:29Z

@li-ho Can you review the latest comment above?

andrew-mclachlan · 2018-05-23T10:26:25Z

Hi @li-ho - logged as #6954.

This may also break GNU ARM Eclipse but haven't tried. Bascially, we're assuming that we can pre-process the LD script which isn't something that GCC Linker supports directly.

li-ho · 2018-05-23T11:55:20Z

Hi @andrew-mclachlan @0xc0170
I am able to export mbed-os-example-blinky with the following command:
mbed export -i gnuarmeclipse -m ev_cog_ad4050lz
and create mbed-os-example-blinky.bin and mbed-os-example-blinky.elf

gnuarmeclipse can be downloaded from
https://github.com/gnu-mcu-eclipse/org.eclipse.epp.packages/releases/download/v4.3.3.20180419-o3a/20180419-1818-gnumcueclipse-4.3.3-oxygen-3a-win32.win32.x86.zip

andrew-mclachlan · 2018-05-23T19:54:08Z

Thanks @li-ho. I'll need to check how it is handling your .LD script and when/how it is being pre-processed. Unfortunately the blinky example won't export and build properly with CrossCore Embedded Studio (analog.com/cces).

andrew-mclachlan · 2018-05-23T19:55:06Z

ADuCM4050.ld is the right linker script for CCES GCC linker.

Indeed but it contains #defines and CCES (CCES) isn't set up to pre-process the LD script.

li-ho · 2018-05-24T00:44:31Z

@andrew-mclachlan You can test your cces projects with mbed-os-5.8.3 or older where ADuCM4050.ld does not contain #defines

I have tried CCES 2.8.0 with mbed-os-5.8.3.

I have also tried CCES 2.8.0 with mbed-os-5.8.5 where ADuCM4050.ld contains #defines, and I get the same error.
Please fix softfp error first with mbed-os-5.8.3.
By the way, can %CCES_HOME% be appended to %PATH% while you install CCES?

andrew-mclachlan · 2018-05-24T05:08:28Z

Thanks!!
It definitely seems that we should address the LD issue and the softfp issue (which looks like an exporter issue) so that we can use the later version(s) of mbed-os.

li-ho · 2018-05-24T06:18:06Z

@andrew-mclachlan The GCC linker of gnuarmeclipse is arm-none-eabi-g++, therefore, #define is readable by GCC linker. You have plenty of toolchain persons on your site to consult with.
Without export,
mbed compile -t gcc_arm -m ev_cog_ad4050lz
can create .link_files.txt and .link_script.ld

andrew-mclachlan · 2018-05-24T10:11:31Z

There's an extra step being done for GNU ARM Eclipse.

CrossCore Embedded Studio just adds the LD script to its Linker command line like so:
arm-none-eabi-g++ -T/home/amclach/mbed-os-example-blinky/cces/../mbed-os/targets/TARGET_Analog_Devices/TARGET_ADUCM4X50/TARGET_ADUCM4050/TOOLCHAIN_GCC_ARM/ADuCM4050.ld -Wl,--gc-sections -Wl,--wrap,main -Wl,--wrap,_malloc_r -Wl,--wrap,_free_r -Wl,--wrap,_realloc_r -Wl,--wrap,_memalign_r -Wl,--wrap,_calloc_r -Wl,--wrap,exit -Wl,--wrap,atexit -Wl,-n -mcpu=cortex-m4 -mthumb -mfpu=fpv4-sp-d16 -mfloat-abi=softfp -lstdc++ -lsupc++ -lm -lc -lgcc -lnosys -mcpu=cortex-m4 -mthumb -specs=nosys.specs -mfpu=fpv4-sp-d16 -mfloat-abi=hard -o "mbed-os-example-blinky" @input-file.txt -lm
Whereas GNU ARM Eclipse creates several pre-processed versions of the LD script:

"arm-none-eabi-cpp" -E -P -DMBED_DEBUG -DMBED_TRAP_ERRORS_ENABLED=1 -Wl,-n -Wl,--start-group -lstdc++ -lsupc++ -lm -lc -lgcc -lnosys -Wl,--end-group ../mbed-os/targets/TARGET_Analog_Devices/TARGET_ADUCM4X50/TARGET_ADUCM4050/TOOLCHAIN_GCC_ARM/ADuCM4050.ld -o linker-script-debug.ld "arm-none-eabi-cpp" -E -P -DNDEBUG -Wl,-n -Wl,--start-group -lstdc++ -lsupc++ -lm -lc -lgcc -lnosys -Wl,--end-group ../mbed-os/targets/TARGET_Analog_Devices/TARGET_ADUCM4X50/TARGET_ADUCM4050/TOOLCHAIN_GCC_ARM/ADuCM4050.ld -o linker-script-release.ld "arm-none-eabi-cpp" -E -P -Wl,-n -Wl,--start-group -lstdc++ -lsupc++ -lm -lc -lgcc -lnosys -Wl,--end-group ../mbed-os/targets/TARGET_Analog_Devices/TARGET_ADUCM4X50/TARGET_ADUCM4050/TOOLCHAIN_GCC_ARM/ADuCM4050.ld -o linker-script-develop.ld

And then adds the pre-processed LD script to its Link command line.
arm-none-eabi-g++ -mcpu=cortex-m4 -mthumb -mfloat-abi=softfp -mfpu=fpv4-sp-d16 -O0 -fmessage-length=0 -ffunction-sections -fdata-sections -fno-builtin -funsigned-char -fno-delete-null-pointer-checks -fomit-frame-pointer -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -g3 -T "/home/amclach/mbed-os-example-blinky/Debug/linker-script-debug.ld" -Xlinker --gc-sections -Xlinker --wrap=main -Xlinker --wrap=_malloc_r -Xlinker --wrap=_free_r -Xlinker --wrap=_realloc_r -Xlinker --wrap=_memalign_r -Xlinker --wrap=_calloc_r -Xlinker --wrap=exit -Xlinker --wrap=atexit -Wl,-Map,"mbed-os-example-blinky.map" -DMBED_DEBUG -DMBED_TRAP_ERRORS_ENABLED=1 -Wl,-n -Wl,--start-group -lstdc++ -lsupc++ -lm -lc -lgcc -lnosys -Wl,--end-group -o "mbed-os-example-blinky.elf"
The additional step that the GNU ARM Eclipse plugins take to pre-process the LD scripts is not a step that CrossCore Embedded Studio takes.

li-ho · 2018-05-24T11:03:31Z

In mbed-os\tools\profiles, you can find the corresponding profiles
debug.json
develop.json
release.json
which produce
linker-script-debug.ld
linker-script-develop.ld
linker-script-release.ld
only one of the three is chosen to build.

They are similar to CCES's debug and release configurations. Only one of the two is chosen to build.

andrew-mclachlan · 2018-05-24T18:19:57Z

In order to solve this issue with CCES #6954, I need to look at adding pre-processing to the build step and an entry box to accept macro defines for the Linker tool similar to GNU ARM Eclipse plugins.

andrew-mclachlan · 2018-07-18T10:16:45Z

CrossCore Embedded Studio (CCES) 2.9.0+ will now pre-process the GCC LD scripts meaning that an ARM mbed project targeting COG boards and exported to CCES will now successfully build.

0xc0170 · 2018-07-18T15:39:06Z

That is great. So just update the studio and all good?

li-ho · 2019-08-02T05:49:05Z

https://download.analog.com/tools/CrossCoreEmbeddedStudio/Releases/Release_2.9.0/ADI_CrossCoreEmbeddedStudio-Rel2.9.0.exe

Edmund Hsu added 3 commits April 20, 2018 15:45

EV_COG_AD4050LZ: Rework linker scripts to support bootloader

beb6a38

- fix compiler warning message of flash_api.c - fix compiler warning message of startup_ADuCM4050.c - eliminate absolute address of ROM tables - add MBED_APP_START and MBED_APP_SIZE to linker scripts

EV_COG_AD3029LZ: Rework linker scripts to support bootloader

e2d9eb8

- fix compiler warning message of flash_api.c - eliminate absolute address of ROM tables - add MBED_APP_START and MBED_APP_SIZE to linker scripts

ADI: Enable bootloader for EV_COG_AD3029LZ and EV_COG_AD4050LZ

e10ef5b

0xc0170 added the needs: CI label Apr 20, 2018

0xc0170 approved these changes Apr 20, 2018

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Apr 20, 2018

cmonr added 5.8.4 release-version: 5.8.4 and removed 5.8.4 labels Apr 23, 2018

cmonr merged commit 38846b2 into ARMmbed:master Apr 23, 2018

cmonr removed the ready for merge label Apr 23, 2018

ADI: Enable bootloader for EV_COG_AD3029LZ and EV_COG_AD4050LZ #6690

ADI: Enable bootloader for EV_COG_AD3029LZ and EV_COG_AD4050LZ #6690

Uh oh!

Conversation

li-ho commented Apr 20, 2018

Description

Pull request type

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

li-ho commented Apr 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Apr 20, 2018

Uh oh!

mbed-ci commented Apr 20, 2018

Build : SUCCESS

Triggering tests

Uh oh!

mbed-ci commented Apr 20, 2018

Exporter Build : SUCCESS

Uh oh!

mbed-ci commented Apr 20, 2018

Test : SUCCESS

Uh oh!

0xc0170 commented May 23, 2018

Uh oh!

andrew-mclachlan commented May 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

li-ho commented May 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrew-mclachlan commented May 23, 2018

Uh oh!

andrew-mclachlan commented May 23, 2018

Uh oh!

li-ho commented May 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrew-mclachlan commented May 24, 2018

Uh oh!

li-ho commented May 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrew-mclachlan commented May 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

li-ho commented May 24, 2018

Uh oh!

andrew-mclachlan commented May 24, 2018

Uh oh!

andrew-mclachlan commented Jul 18, 2018

Uh oh!

0xc0170 commented Jul 18, 2018

Uh oh!

li-ho commented Aug 2, 2019

Uh oh!

Uh oh!

li-ho commented Apr 20, 2018 •

edited

Loading

andrew-mclachlan commented May 23, 2018 •

edited

Loading

li-ho commented May 23, 2018 •

edited

Loading

li-ho commented May 24, 2018 •

edited

Loading

li-ho commented May 24, 2018 •

edited

Loading

andrew-mclachlan commented May 24, 2018 •

edited

Loading