New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootloader support for NUCLEO_F411RE target #6729

Merged
merged 1 commit into from May 3, 2018

Conversation

Projects
None yet
6 participants
@JammuKekkonen
Contributor

JammuKekkonen commented Apr 24, 2018

Description

Add bootloader support for NUCLEO_F411RE board.

Tested with mbed-bootloader + blinky, with all three compilers.

Ref: #5228 - bootloader support for NUCLEO_F446RE

Pull request type

[ ] Fix
[ ] Refactor
[X] New target
[ ] Feature
[ ] Breaking change
@JammuKekkonen

This comment has been minimized.

Contributor

JammuKekkonen commented Apr 24, 2018

@JanneKiiskila

This comment has been minimized.

Contributor

JanneKiiskila commented Apr 24, 2018

@kjbracey-arm - can we get this reviewed?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 24, 2018

@ARMmbed/team-st-mcd Please review

#endif
#if !defined(MBED_APP_SIZE)
#define MBED_APP_SIZE 0x100000

This comment has been minimized.

@jeromecoutant

jeromecoutant Apr 24, 2018

Contributor

Should be 0x80000 ?

This comment has been minimized.

@LMESTM

LMESTM Apr 24, 2018

Contributor

Good catch - target has 512K (0x80000)

@@ -1,7 +1,10 @@
if (!isdefinedsymbol(MBED_APP_START)) { define symbol MBED_APP_START = 0x08000000; }
if (!isdefinedsymbol(MBED_APP_SIZE)) { define symbol MBED_APP_SIZE = 0x100000; }

This comment has been minimized.

@jeromecoutant

jeromecoutant Apr 24, 2018

Contributor

Should be 0x80000 ?

This comment has been minimized.

@LMESTM

LMESTM Apr 24, 2018

Contributor

+1

@JammuKekkonen JammuKekkonen force-pushed the JammuKekkonen:f411re_add_bootloader_support branch from a891696 to 3a1de91 Apr 24, 2018

@JammuKekkonen

This comment has been minimized.

Contributor

JammuKekkonen commented Apr 24, 2018

PR updated

define symbol __region_ROM_end__ = 0x0807FFFF;
define symbol __intvec_start__ = MBED_APP_START;
define symbol __region_ROM_start__ = MBED_APP_START;
define symbol __region_ROM_end__ = MBED_APP_START + MBED_APP_SIZE;

This comment has been minimized.

@jeromecoutant

jeromecoutant Apr 24, 2018

Contributor

define symbol region_ROM_end = MBED_APP_START + MBED_APP_SIZE -1; ?

@JammuKekkonen JammuKekkonen force-pushed the JammuKekkonen:f411re_add_bootloader_support branch from 3a1de91 to 10668fa Apr 25, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 26, 2018

@jeromecoutant Happy with the changes?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 26, 2018

@JammuKekkonen Please review jenkins failure, linking errors related to the changes here

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 26, 2018

@JammuKekkonen JammuKekkonen force-pushed the JammuKekkonen:f411re_add_bootloader_support branch from 10668fa to d2cf341 Apr 26, 2018

@JammuKekkonen

This comment has been minimized.

Contributor

JammuKekkonen commented Apr 26, 2018

New try. Added the missing armcc preprocessor directive.

@0xc0170 0xc0170 added needs: review and removed needs: work labels Apr 26, 2018

@adbridge adbridge requested a review from kjbracey-arm Apr 30, 2018

@0xc0170

0xc0170 approved these changes May 2, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 2, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 2, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented May 2, 2018

Build : SUCCESS

Build number : 1890
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6729/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 45b3fff into ARMmbed:master May 3, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9264 cycles (-940 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment