New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enlarge timer thread stack size for Cortex-M23/M33 #6773

Merged
merged 3 commits into from May 7, 2018

Conversation

Projects
None yet
5 participants
@ccli8
Contributor

ccli8 commented Apr 30, 2018

Description

This PR tries to enlarge default size of timer thread stack for Cortex-M23/M33 targets. The adjustment is based on port of our on-going NUMAKER_PFM_M2351 target.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@deepikabhavnani deepikabhavnani requested a review from c1728p9 Apr 30, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Apr 30, 2018

Increasing timer stack size for all devices (including the ones which do not support trustZone and have limited RAM memory) does not make sense. Shall we have config option for timer stack size?

@ccli8

This comment has been minimized.

Contributor

ccli8 commented May 2, 2018

@deepikabhavnani I change back the default size of timer thread but keep the configuration option for it in 438788b.

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented May 2, 2018

@ccli8 - Having config option is good. It will be good to have additional define MBED_CONF_xxx as config similar to others (MBED_CONF_APP_THREAD_STACK_SIZE)

@ccli8 ccli8 force-pushed the OpenNuvoton:nuvoton_fix_timer_stack_size branch from 438788b to 7b94d4d May 3, 2018

@ccli8

This comment has been minimized.

Contributor

ccli8 commented May 3, 2018

@deepikabhavnani I add the macros MBED_CONF_APP_TIMER_THREAD_STACK_SIZE/MBED_CONF_APP_IDLE_THREAD_STACK_SIZE for configuration by user application.

@0xc0170 0xc0170 requested a review from deepikabhavnani May 3, 2018

@deepikabhavnani

Looks good to me 👍

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 3, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 3, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented May 3, 2018

Build : SUCCESS

Build number : 1914
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6773/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

0xc0170 approved these changes May 4, 2018 edited

@deepikabhavnani Any documentation needed for this extension?

Having this configuration documented for rtos like main thread stack size, this timer thread stack size, etc ?

@mbed-ci

This comment has been minimized.

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented May 4, 2018

Any documentation needed for this extension?

👍 Added PR in handbook. ARMmbed/mbed-os-5-docs#510

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 7, 2018

@cmonr

cmonr approved these changes May 7, 2018

@cmonr cmonr merged commit 7a99cd1 into ARMmbed:master May 7, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 582 warnings (+0 warnings)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9565 cycles (-474 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10112B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment