Skip to content

Conversation

li-ho
Copy link

@li-ho li-ho commented May 18, 2018

Description

Rework adi_rtc.c:

  • Preserve RTC counter value while re-initialization
  • Remove trailing spaces

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

Steps to reproduce

mbed test -t arm -m ev_cog_ad3029lz -n tests-mbed_hal-rtc*

Expected test results

+---------------------+-----------------+--------------------------------------+-----------------------------------------------------------------+--------+--------+--------+--------------------+
| target              | platform_name   | test suite                           | test case                                                       | passed | failed | result | elapsed_time (sec) |
+---------------------+-----------------+--------------------------------------+-----------------------------------------------------------------+--------+--------+--------+--------------------+
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc           | RTC - accuracy                                                  | 1      | 0      | OK     | 10.05              |
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc           | RTC - enabled                                                   | 1      | 0      | OK     | 0.05               |
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc           | RTC - glitch                                                    | 1      | 0      | OK     | 4.05               |
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc           | RTC - init                                                      | 1      | 0      | OK     | 0.05               |
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc           | RTC - persist                                                   | 1      | 0      | OK     | 4.03               |
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc           | RTC - range                                                     | 1      | 0      | OK     | 16.0               |
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc           | RTC - write/read                                                | 1      | 0      | OK     | 0.05               |
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc_reset     | mbed-os-tests-mbed_hal-rtc_reset                                | 1      | 0      | OK     | 18.77              |
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc_time      | test is leap year - RTC leap years full support                 | 1      | 0      | OK     | 0.08               |
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc_time      | test is leap year - RTC leap years partial support              | 1      | 0      | OK     | 0.1                |
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc_time      | test local time - invalid param                                 | 1      | 0      | OK     | 0.06               |
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc_time      | test make time - invalid param                                  | 1      | 0      | OK     | 0.07               |
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc_time      | test make time boundary values - RTC leap years full support    | 1      | 0      | OK     | 0.1                |
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc_time      | test make time boundary values - RTC leap years partial support | 1      | 0      | OK     | 0.11               |
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc_time_conv | test make time and local time - RTC leap years full support     | 1      | 0      | OK     | 12.28              |
| EV_COG_AD3029LZ-ARM | EV_COG_AD3029LZ | mbed-os-tests-mbed_hal-rtc_time_conv | test make time and local time - RTC leap years partial support  | 1      | 0      | OK     | 12.2               |
+---------------------+-----------------+--------------------------------------+-----------------------------------------------------------------+--------+--------+--------+--------------------+

@li-ho
Copy link
Author

li-ho commented May 18, 2018

CC : @maclobdell @bentcooke

@0xc0170 0xc0170 requested a review from c1728p9 May 18, 2018 09:02
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split style changes from code changes? Commit rework rtc should be split into 2.

@0xc0170 0xc0170 removed the request for review from c1728p9 May 18, 2018 09:04
@li-ho
Copy link
Author

li-ho commented May 18, 2018

@0xc0170 coding style and rework are separated.

@0xc0170
Copy link
Contributor

0xc0170 commented May 20, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 20, 2018

Build : FAILURE

Build number : 2075
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6946/

@0xc0170
Copy link
Contributor

0xc0170 commented May 20, 2018

@AnttiKauppila Has anything changed causing a failure in lorawan example for this PR? Please review

@AnttiKauppila
Copy link

@kivaisan Can you check this asap.

@kivaisan
Copy link
Contributor

@0xc0170 Why lorawan example is still built for these targets? See commit: e533b41

@li-ho
Copy link
Author

li-ho commented May 22, 2018

Apparently, the "targets" in mbed-os\tools\test\examples\examples.json does not make sense.
EV_COG_AD4050LZ cannot be built in mbed-os-example-ble because there'are no features name "BLE" and no extra_label "ST_BLUENRG".
Do you consider lorawan a feature or a must? How to disable a feature because there's no adequate MCU SRAM to run an example?

@0xc0170
Copy link
Contributor

0xc0170 commented May 22, 2018

@li-ho This is a bug in our tools or CI. We are investigating. Your target wont be built for lorawan or ble (only those specified in targets should be for features like these).

@0xc0170
Copy link
Contributor

0xc0170 commented May 22, 2018

@c1728p9 @bulislaw Can you please rebase RTC branch ? There's a fix on master. Will resolve the build error.

@bulislaw bulislaw force-pushed the feature-hal-spec-rtc branch from 2f37602 to 2b377bd Compare May 23, 2018 17:18
@bulislaw
Copy link
Member

Feature branch rebased, please rebase your PR.

@bulislaw bulislaw merged commit 76946da into ARMmbed:feature-hal-spec-rtc May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants