New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 ETH : remove TX RX locking interrupt perforation #6948

Merged
merged 1 commit into from Jun 11, 2018

Conversation

Projects
None yet
7 participants
@jeromecoutant
Contributor

jeromecoutant commented May 18, 2018

Description

See #6610 for detailed analysis

@pauluap
I have updated F7 file, as I think you miss some LOCK and UNLOCK ?

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested review from kjbracey-arm and ARMmbed/team-st-mcd May 18, 2018

@pauluap

This comment has been minimized.

pauluap commented May 18, 2018

@jeromecoutant, my intention was only to resolve the perforation issue. I didn't touch the other HAL locks because I didn't really understand their purpose. HAL locking seems to be a fundamental part of the STMCube design.

It seems that you have determined that HAL locking isn't necessary for the MAC HAL module. That's cool, good information to know.

I have no information that suggests that this will (or will not for that matter) be an issue. For mbed at least, I don't project any problems since the mac configuration is done from a single thread, the phy register read, rx and tx seem to be just fine running in different threads.

@pauluap

This comment has been minimized.

pauluap commented May 18, 2018

@jeromecoutant Oops, I stand corrected. Yes, you're right, I missed the updating the non-_IT versions in F7 because my code wasn't using those. I'm glad that you caught the one at the end of GetReceivedFrame_IT, in removing one perforation, I introduced another!

My apologizes

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented May 23, 2018

@bcostm @kjbracey-arm

Any comment ? Thx

@bcostm

bcostm approved these changes Jun 5, 2018

@0xc0170

0xc0170 approved these changes Jun 6, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 6, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 8, 2018

/morph build

1 similar comment
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 8, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 8, 2018

Build : SUCCESS

Build number : 2286
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6948/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 8, 2018

Pausing CI until 5.9 RC3 completes CI. Will restart jobs when able.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 9, 2018

/morph test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 3d61cb5 into ARMmbed:master Jun 11, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 845 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9987 cycles (+1149 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_ETHER branch Jun 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment