Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cellular: release resources in state machine. #6962

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Cellular: release resources in state machine. #6962

merged 1 commit into from
Jun 14, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented May 21, 2018

Description

Release resources in state machine.
Made sure that athandler does not try process urc's after switch to data mode.

Internal ref to defect: IOTCELL-846

@AriParkkila @mirelachirica please review

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

mirelachirica
mirelachirica previously approved these changes May 22, 2018
View reviewed changes
@0xc0170 0xc0170 requested a review from a team May 22, 2018 08:43
AnttiKauppila
AnttiKauppila previously approved these changes May 22, 2018
View reviewed changes
@cmonr
Copy link
Contributor

cmonr commented May 31, 2018

Looks good. Once this is rebased, we'll run CI.

@jarvte jarvte dismissed stale reviews from AnttiKauppila and mirelachirica via 9cbef81 June 4, 2018 05:51
@jarvte jarvte force-pushed the release_resources_cellular_statemachine branch 2 times, most recently from 9cbef81 to 6630bae Compare June 4, 2018 06:54
@jarvte
Copy link
Contributor Author

jarvte commented Jun 4, 2018

@cmonr rebase done.

@jarvte
Copy link
Contributor Author

jarvte commented Jun 4, 2018

@cmonr something wrong with the travis-ci/pr not related to this pr...

@cmonr
Copy link
Contributor

cmonr commented Jun 4, 2018

Huh. Haven't seen a key failure in Travis in a while.

It's been restarted.

@cmonr
Copy link
Contributor

cmonr commented Jun 4, 2018

@AnttiKauppila @mirelachirica Mind doing a re-review?

AnttiKauppila
AnttiKauppila previously approved these changes Jun 4, 2018
View reviewed changes
@AnttiKauppila
Copy link

@cmonr Done

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

Build : SUCCESS

Build number : 2268
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6962/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@cmonr
Copy link
Contributor

cmonr commented Jun 7, 2018

Halting CI builds until RC3 PRs are completed. Will resume after.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2018

/morph test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2018

Exporter Build : SUCCESS

Build number : 1908
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6962/

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2018

Test : SUCCESS

Build number : 2066
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6962/2066

kjbracey
kjbracey previously approved these changes Jun 11, 2018
View reviewed changes
@jarvte
Copy link
Contributor Author

jarvte commented Jun 11, 2018

@0xc0170 please merge

@cmonr
Copy link
Contributor

cmonr commented Jun 11, 2018

@jarvte Sorry, but it looks like another rebase is needed.

@cmonr
Copy link
Contributor

cmonr commented Jun 11, 2018

Will put this into CI as soon as the rebase is complete since reviewers already gave the ok.

Cellular: release resources in state machine. Made sure that athandle…
d9a99b0 
…r does not try process urc's after switch to data mode.
@jarvte jarvte dismissed stale reviews from kjbracey and AnttiKauppila via d9a99b0 June 12, 2018 06:01
@jarvte jarvte force-pushed the release_resources_cellular_statemachine branch from 6630bae to d9a99b0 Compare June 12, 2018 06:01
@jarvte
Copy link
Contributor Author

jarvte commented Jun 12, 2018

@cmonr rebase done

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 12, 2018

/morph build

0xc0170
0xc0170 approved these changes Jun 12, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approved, rebased

@mbed-ci
Copy link

mbed-ci commented Jun 12, 2018

Build : SUCCESS

Build number : 2332
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6962/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 12, 2018

Exporter Build : SUCCESS

Build number : 1954
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6962/

@mbed-ci
Copy link

mbed-ci commented Jun 13, 2018

Test : SUCCESS

Build number : 2112
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6962/2112

@AriParkkila AriParkkila mentioned this pull request Jun 14, 2018
Closed
@cmonr cmonr merged commit ac107e9 into ARMmbed:master Jun 14, 2018
@jarvte jarvte deleted the release_resources_cellular_statemachine branch June 15, 2018 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey kjbracey left review comments

@AnttiKauppila AnttiKauppila AnttiKauppila left review comments

@mirelachirica mirelachirica mirelachirica left review comments

Assignees
No one assigned
Labels
release-version: 5.9.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jarvte @cmonr @AnttiKauppila @0xc0170 @mbed-ci @kjbracey @mirelachirica