New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test build: Reduce include command length #6968

Merged
merged 1 commit into from May 23, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented May 21, 2018

Description

Resolves #6577

Tests are built in two passes:

  • Mbed OS as a lib (just .o files)
  • Each test is built and linked with the Mbed OS .o

The second pass involves scanning the build directory creating in the first
pass. This is where the bug lies: the second pass takes an absolute path to
the artifacts create by the first. This adds the directory containing mbed-os
to the each include path, and these extra characters exceed the maximum
command line length on windows.

This patch uses a relate path, eliminating the problem

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 added the needs: CI label May 22, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 22, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 22, 2018

Build : SUCCESS

Build number : 2096
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6968/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 22, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels May 23, 2018

@cmonr cmonr merged commit 99df848 into ARMmbed:master May 23, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 845 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10048 cycles (+434 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment