Skip to content

Conversation

mmahadevan108
Copy link
Contributor

Signed-off-by: Mahesh Mahadevan mahesh.mahadevan@nxp.com

Description

The changes as part of #6956 should allow us to turn on SLEEP on KW41Z. All tests pass.

Do we need to turn it on in this branch as well? This patch enables SLEEP on KW41Z, but requires changes from PR 6956.

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
Copy link
Contributor Author

cc @maclobdell @0xc0170 @bulislaw

Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run CI.

@0xc0170
Copy link
Contributor

0xc0170 commented May 23, 2018

We will run CI as soon as we could (currently some other features need to be completed)

@0xc0170
Copy link
Contributor

0xc0170 commented May 23, 2018

The fastest way to go forward in cases like this (when multiple PR are opened against one branch) would be to merge all targets PR for a feature branch to one integration branch and run it through CI once (github will close this automatically one integration branch gets in).

@bulislaw bulislaw merged commit 371b34a into ARMmbed:feature-hal-spec-sleep May 23, 2018
@cmonr cmonr removed the needs: CI label Jun 19, 2018
@mmahadevan108 mmahadevan108 deleted the feature-hal-spec-sleep-KW41Z branch October 2, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants