New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible bug with SysTimer #7027

Merged
merged 1 commit into from May 31, 2018

Conversation

Projects
None yet
7 participants
@c1728p9
Contributor

c1728p9 commented May 27, 2018

Ensure the SysTimer isn't added to the timer list twice by adding an extra call to remove() inside suspend().

Description

@stevew817 has reported a problem with SysTimer which this PR fixes.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Fix possible bug with SysTimer
Ensure the SysTimer isn't added to the timer list twice by adding
an extra call to remove() inside suspend().
@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented May 27, 2018

Note - I have not actually been able to reproduce this failure, so it may not affect the latest master.

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented May 27, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented May 27, 2018

Build : SUCCESS

Build number : 2170
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7027/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-core May 28, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 29, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit f92c227 into ARMmbed:master May 31, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 908 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9002 cycles (-1011 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: review label May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment