Fix for filename capture not working

[SenRamakri]

Description

This is the fix for #7025
There was a bug in the code where in filename capture wont work properly and also we should disable filename capture release builds. This change fixes that.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

[SenRamakri]

This is a bug fix and we should try to get this in for 5.9. Is this something which can go into 5.9 RC2?

[0xc0170]

If this is found during oob then in the next release candidate, otherwise the next patch release.

I assume this goes to the next patch release.

[0xc0170]

Can be the first commit extended ?one liner for those changes do not look sufficient (how is it fixing the bug?)

[SenRamakri]

@0xc0170 - Please see my change to function handle_error for the fix.

[cmonr]

Code changes look good to me, but echoing @0xc0170 sentiment about the code changes vs commit message.

Either more detail should be added to that first commit message, or it should be split into two, since that single commit also contains the NDEBUG additions.

[SenRamakri]

@0xc0170 @cmonr - Good point, I'll split them into separate commits and re-push.

[SenRamakri]

@cmonr @0xc0170 - I have split the commits as you suggested plus one more change to fix error report generation when calling error API, please review.

[cmonr]

LGTM

[cmonr]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 2211
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7050/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Test : SUCCESS

Build number : 2004
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7050/2004

[cmonr]

/morph uvisor-test

[mbed-ci]

Exporter Build : ABORTED

Build number : 1838
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7050/

[cmonr]

/morph export-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 1848
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7050/

[cmonr]

/morph uvisor-test

[0xc0170]

/morph uvisor-test

[0xc0170]

@orenc17 Please help to restart this job