-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for filename capture not working #7050
Conversation
This is a bug fix and we should try to get this in for 5.9. Is this something which can go into 5.9 RC2? |
If this is found during oob then in the next release candidate, otherwise the next patch release. I assume this goes to the next patch release. |
Can be the first commit extended ?one liner for those changes do not look sufficient (how is it fixing the bug?) |
@0xc0170 - Please see my change to function handle_error for the fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me, but echoing @0xc0170 sentiment about the code changes vs commit message.
Either more detail should be added to that first commit message, or it should be split into two, since that single commit also contains the NDEBUG additions.
23fa1bc
to
576bd61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/morph build |
Build : SUCCESSBuild number : 2211 Triggering tests/morph test |
Test : SUCCESSBuild number : 2004 |
/morph uvisor-test |
Exporter Build : ABORTEDBuild number : 1838 |
/morph export-build |
Exporter Build : SUCCESSBuild number : 1848 |
/morph uvisor-test |
/morph uvisor-test |
@orenc17 Please help to restart this job |
Description
This is the fix for #7025
There was a bug in the code where in filename capture wont work properly and also we should disable filename capture release builds. This change fixes that.
Pull request type