Add TRNG API test #7057

theamirocohen · 2018-05-30T11:53:27Z

Use TRNG api to construct different buffers and try to compress them, If the random data is not really random, the test will be able to compress it.
We also check that after device reset when we use TRNG the API will create different data.

We do use lzf lib to compress the random buffer, the library should be checked for copyrights violation by @ChiefBureaucraticOfficer , all files are documented and under the lzflib library.

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

0xc0170 · 2018-05-30T11:57:37Z

TESTS/mbed_hal/trng/main.cpp

This can be ASSERT with msg (then printf not needed). I think this entire if can be turned into one assert.

Similar to: TEST_ASSERT_TRUE_MSG(compr_res < buffer_len , "failed......msg....here")

Because the test contains several parts I wanted the user to have a clear view of the progress, the assert message is only shown when the test fails.

0xc0170 · 2018-05-30T11:58:15Z

TESTS/mbed_hal/trng/main.cpp

Can you fix formatting (follow mbed OS code style) , this one ({) should be attached

Sorry for that, all formatting will be fixed

0xc0170 · 2018-05-30T11:59:51Z

TESTS/mbed_hal/trng/base64b/base64b.h

license header missing in some files (please review), not only this one

Sorry for that, all license header will be added.

0xc0170 · 2018-05-30T12:06:08Z

From the changes, looks like mbed tls and strorage teams should review this PR?

ghost · 2018-05-30T12:53:52Z

This appears to have a GPL on it. @0xc0170

theamirocohen · 2018-05-30T14:28:45Z

@ARMmbed/mbed-os-storage
@ARMmbed/mbed-os-tls
Hope you can help review PR

ghost · 2018-05-30T14:31:10Z

GPL is still present in this PR. We cannot integrate GPL code with Mbed OS.

theamirocohen · 2018-06-04T10:55:52Z

Compression lib was changed to pithy (with BSD license)

theamirocohen · 2018-06-04T13:45:17Z

@dannybenor

simonbutcher · 2018-06-04T13:47:39Z

You need @ARMmbed/mbed-os-crypto to review this, not @ARMmbed/mbed-os-tls!

As seems to be common these days, we may be duplicating work, and I believe the Crypto team were planning on providing their own statistical measurement of the TRNG.

cc: @Patater, @yanesca

License headers added.

cmonr · 2018-06-18T23:17:00Z

@ARMmbed/mbed-os-crypto Mind reviewing?

yanesca · 2018-06-19T14:49:34Z

@cmonr We'll review it shortly! Could you please add the "TLS" label to the PR?

yanesca

Looks good to me!

@mohammad1603 will be giving a review too and we need his approval before merging.

cmonr · 2018-06-22T21:23:48Z

Thansk for the heads up @yanesca

mohammad1603

looks good to me, some minor issues

mohammad1603 · 2018-06-21T11:18:55Z

TESTS/host_tests/trng_reset.py

typo: ~~lading~~ -> loading

mohammad1603 · 2018-06-21T11:20:12Z

TESTS/host_tests/trng_reset.py

what do you mean "device is NVstore" ?

"default lading and storing while reseting the device is NVstore", the device is the device used for testing, the NVstore is one way of storing and loading data

mohammad1603 · 2018-06-23T11:34:11Z

TESTS/host_tests/trng_reset.py

do you expect the device to reset after step1 (dummy message) ?

Yes, If not an error will occur.

mohammad1603 · 2018-06-23T11:39:00Z

TESTS/mbed_hal/trng/base64b/base64b.cpp

Style (minor): mixed style of using {.

if (a){ xx; }

AND

if (a) { xx; }

mohammad1603 · 2018-06-23T11:55:44Z

TESTS/mbed_hal/trng/base64b/base64b.cpp

i think you should switch between the first two conditions - the current code can cause an out of bounds access.
in case the string doesn't end with 0 you can see this behavior.
should be:

while (( currPos < stringMaxSize ) && ( string[currPos] != 0 ) && ( writePtr < bufferEnd ) && ( !isEndOfString )) {

mohammad1603 · 2018-06-23T11:57:03Z

TESTS/mbed_hal/trng/base64b/base64b.cpp

in the while you validate this, you can avoid this checks (they will always be true)

mohammad1603 · 2018-06-23T12:04:04Z

TESTS/mbed_hal/trng/base64b/base64b.cpp

if currPos == stringMaxSize this can be a problem as above

mohammad1603 · 2018-06-23T12:23:50Z

TESTS/mbed_hal/trng/main.cpp

typo: ~~acuur~~ -> occur

dannybenor

Before approving this PR, TPIP must be approved by Aaron

cmonr · 2018-06-25T00:23:20Z

@dannybenor TPIP?

ghost · 2018-06-25T20:00:49Z

@cmonr - TPIP == Third Party IP. This looks to be BSD, which is compatible. I'll run it past legal for a TPIP review just to be sure.

cmonr · 2018-07-05T22:18:10Z

@ChiefBureaucraticOfficer Is this good to progress?

theamirocohen · 2018-09-12T09:02:30Z

Hi @0xc0170 ,
In internal checks we see that K22 is running properly, the fail might have been a statistical issue, where the string did have a similarity and compressed.
Any how @yossi2le added tests prints so we could track any error if it will fail again.
Can we run morph build again please.
Thanks!

cmonr · 2018-09-12T13:23:10Z

/morph test

mbed-ci · 2018-09-12T21:00:35Z

Test : FAILURE

Build number : 2838
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7057/2838

cmonr · 2018-09-12T22:13:00Z

Oh, I feel silly. This needed to have been a build, not a re-test.

/morph build

mbed-ci · 2018-09-12T23:44:02Z

Build : SUCCESS

Build number : 3067
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7057/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-09-13T03:35:58Z

Exporter Build : SUCCESS

Build number : 2679
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7057/

NirSonnenschein · 2018-09-16T08:23:25Z

/morph build

mbed-ci · 2018-09-16T09:27:35Z

Build : SUCCESS

Build number : 3073
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7057/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-09-16T11:05:28Z

Test : FAILURE

Build number : 2864
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7057/2864

NirSonnenschein · 2018-09-16T11:25:01Z

TRNG test seem to fail on K22F. @theamirocohen please take a look.

mbed-ci · 2018-09-16T13:28:14Z

Exporter Build : SUCCESS

Build number : 2686
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7057/

cmonr · 2018-09-25T15:54:33Z

/morph build

mbed-ci · 2018-09-25T16:53:18Z

Build : SUCCESS

Build number : 3156
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7057/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-09-25T19:28:48Z

Exporter Build : SUCCESS

Build number : 2760
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7057/

mbed-ci · 2018-09-26T00:39:15Z

Test : FAILURE

Build number : 2966
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7057/2966

cmonr · 2018-09-26T03:24:41Z

sigh

It looks like failure was an intermittent network issue.

/morph test

mbed-ci · 2018-09-26T05:30:09Z

Test : SUCCESS

Build number : 2967
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7057/2967

0xc0170 previously requested changes May 30, 2018

View reviewed changes

0xc0170 added the needs: work label May 30, 2018

0xc0170 requested a review from a user May 30, 2018 13:01

ghost added the do not merge label May 30, 2018

adbridge requested a review from a team June 4, 2018 13:55

cmonr added needs: review and removed do not merge needs: work labels Jun 4, 2018

cmonr removed the request for review from a user June 18, 2018 23:17

cmonr added tracking component: security labels Jun 19, 2018

cmonr requested a review from a team June 19, 2018 18:27

yanesca previously approved these changes Jun 22, 2018

View reviewed changes

0xc0170 requested a review from mohammad1603 June 22, 2018 12:55

mohammad1603 suggested changes Jun 23, 2018

View reviewed changes

dannybenor reviewed Jun 24, 2018

View reviewed changes

cmonr removed the release-version: 5.9.7 label Sep 5, 2018

yossi2le force-pushed the trng_test branch from 000bdab to 79e5111 Compare September 6, 2018 10:52

cmonr added needs: CI and removed needs: work labels Sep 12, 2018

NirSonnenschein added needs: work and removed needs: CI labels Sep 16, 2018

Fix print error

e92f41a

cmonr added needs: CI and removed needs: work labels Sep 25, 2018

NirSonnenschein added ready for merge and removed needs: CI labels Sep 26, 2018

0xc0170 merged commit a0a9b54 into ARMmbed:master Sep 26, 2018

0xc0170 removed the ready for merge label Sep 26, 2018

Add TRNG API test #7057

Add TRNG API test #7057

Uh oh!

Conversation

theamirocohen commented May 30, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented May 30, 2018

Uh oh!

ghost commented May 30, 2018

Uh oh!

theamirocohen commented May 30, 2018

Uh oh!

ghost commented May 30, 2018

Uh oh!

theamirocohen commented Jun 4, 2018

Uh oh!

theamirocohen commented Jun 4, 2018

Uh oh!

simonbutcher commented Jun 4, 2018

Uh oh!

cmonr commented Jun 18, 2018

Uh oh!

yanesca commented Jun 19, 2018

Uh oh!

yanesca left a comment

Choose a reason for hiding this comment

Uh oh!

cmonr commented Jun 22, 2018

Uh oh!

mohammad1603 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dannybenor left a comment

Choose a reason for hiding this comment

Uh oh!

cmonr commented Jun 25, 2018

Uh oh!

ghost commented Jun 25, 2018

Uh oh!

cmonr commented Jul 5, 2018

Uh oh!

theamirocohen commented Sep 12, 2018

Uh oh!

cmonr commented Sep 12, 2018

Uh oh!

mbed-ci commented Sep 12, 2018

Uh oh!

cmonr commented Sep 12, 2018