New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS version not update in mbed_stats #7059

Merged
merged 1 commit into from May 31, 2018

Conversation

Projects
None yet
8 participants
@deepikabhavnani
Contributor

deepikabhavnani commented May 30, 2018

Description

Temporary fix to remove OS version update, it will be always zero (even in release versions)

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

CC @0xc0170

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-core May 30, 2018

@0xc0170

LGTM

Where should this be documented? Should version member contain a note that this is now 0 as known issue ?

Should this be added to known issue? I assume we will fix this in 5.9.1

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 30, 2018

How does this affect an example system stats? do we nee dto do any change there?

cc @MarceloSalazar

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented May 30, 2018

How does this affect an example system stats? do we nee dto do any change there?

Example will show version as 0 always. It will be good to document it as known issue. @AnotherButler Shall I add know issue in API reference (handbook) or it should be part of known issues section in Release notes

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 30, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels May 30, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented May 31, 2018

Build : SUCCESS

Build number : 2198
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7059/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@adbridge

This comment has been minimized.

Contributor

adbridge commented May 31, 2018

mbed OS versions are only applicable in releases. There will never be an OS version on master....This was removed about a year ago.

@adbridge

This comment has been minimized.

Contributor

adbridge commented May 31, 2018

@studavekar Looks like we are out of disk space again. Can you take a look please ?

@studavekar

This comment has been minimized.

Collaborator

studavekar commented May 31, 2018

@studavekar Looks like we are out of disk space again. Can you take a look please ?

@adbridge where did you find traceback of out of disk space? Looking at logs I see ping timeout may be lost connection with node

00:52:27.798 hudson.remoting.ProxyException: java.util.concurrent.TimeoutException: Ping started at 1527733281669 hasn't completed by 1527733989107
00:52:27.798 Caused: Command close created at
00:52:27.798 	at hudson.remoting.Command.<init>(Command.java:60)
00:52:27.798 	at hudson.remoting.Channel$CloseCommand.<init>(C
@studavekar

This comment has been minimized.

Collaborator

studavekar commented May 31, 2018

/morph test

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 31, 2018

Correct, looks like nodes decided to go on a silent strike.
@studavekar just restarted the tests.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 31, 2018

@AnotherButler Ping?

This is ready to go, but I don't want to lose the doc update.

@AnotherButler

This comment has been minimized.

Contributor

AnotherButler commented May 31, 2018

Let's add this to the known issues list in the release notes.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 31, 2018

Fyi @adbridge

@cmonr cmonr merged commit 52cb119 into ARMmbed:master May 31, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 918 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8772 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label May 31, 2018

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:os_verison_fix branch May 31, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Jun 1, 2018

@deepikabhavnani @0xc0170 @cmonr

OK so I am not sure I understand the necessity for this patch? On ALL release branches mbed.h contains:

#define MBED_VERSION MBED_ENCODE_VERSION(MBED_MAJOR_VERSION, MBED_MINOR_VERSION, MBED_PATCH_VERSION) 

stats->os_version is initialised to 0 anyway so this would work fine as it is ? It would report 0 on master where MBED_VERSION is not defined and a real release on a release branch where it is?

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Jun 1, 2018

@adbridge - This is failing because we do not include "mbed.h" inside platform or internal header files. And version number is not available in Mbed OS source code. Correct solution will be to create a separate header file for version details and include that in "mbed.h" and anywhere else as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment