New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the tolerance to 5% if NO_SYSTICK is enabled #7070

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
8 participants
@ithinuel
Member

ithinuel commented May 31, 2018

Description

Fixes the issue raised on CI on the NRF 51 device.
The value of 5% is chosen to match the tolerance applied to lp_tickers that are also often RTC-backed.

Related PR

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@adbridge

This comment has been minimized.

Contributor

adbridge commented May 31, 2018

@ithinuel Looks like a possible real error on pr-head:

Build failures:

  * K64F::ARM::TESTS-MBED_DRIVERS-TIMER

        Building project timer (K64F, ARM)

        Scan: ARM

        Scan: timer

        Scan: FEATURE_LWIP

        Scan: FEATURE_STORAGE

        Compile [100.0%]: main.cpp

        [Error] main.cpp@415,0:  #19: extra text after expected end of number

        [Error] main.cpp@437,0:  #19: extra text after expected end of number

        [Error] main.cpp@458,0:  #19: extra text after expected end of number

        [Error] main.cpp@480,0:  #19: extra text after expected end of number

        [Error] main.cpp@509,0:  #19: extra text after expected end of number

        [Error] main.cpp@527,0:  #19: extra text after expected end of number

        [Error] main.cpp@611,0:  #19: extra text after expected end of number

        [Error] main.cpp@648,0:  #19: extra text after expected end of number

        [Error] main.cpp@675,0:  #19: extra text after expected end of number

        [Error] main.cpp@730,0:  #19: extra text after expected end of number

@adbridge adbridge requested a review from ARMmbed/mbed-os-core May 31, 2018

@ithinuel ithinuel force-pushed the ithinuel:increase_tolerance_for_systick_less_devices branch from 157a60a to 3745c73 May 31, 2018

@cmonr cmonr requested a review from bulislaw May 31, 2018

@cmonr cmonr added needs: CI and removed needs: review labels May 31, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 31, 2018

/morph build

@cmonr cmonr referenced this pull request May 31, 2018

Merged

Wise 1510 uart config #6803

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 1, 2018

Build : SUCCESS

Build number : 2214
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7070/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 2, 2018

/morph uvisor-test

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 2, 2018

/morph uvisor-test

1 similar comment
@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 3, 2018

/morph uvisor-test

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Jun 4, 2018

This bug(test failures) likely arose when NRF51 us_ticker implementation was changed from rtc to timer based (9ef0083). Before both lp_ticker and us_ticker were rtc based

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 4, 2018

/morph uvisor-test

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 4, 2018

@c1728p9 c1728p9 referenced this pull request Jun 4, 2018

Merged

tests-mbed_hal-sleep fix #7036

@cmonr cmonr merged commit 583d77f into ARMmbed:master Jun 4, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 918 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8833 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment