New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit warning about FEATURE_UVISOR being deprecated #7072

Merged
merged 2 commits into from Jun 4, 2018

Conversation

Projects
None yet
7 participants
@orenc17
Contributor

orenc17 commented May 31, 2018

Description

Edit uVisor deprecation warning.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@orenc17

This comment has been minimized.

Contributor

orenc17 commented May 31, 2018

@adbridge adbridge requested review from cmonr, 0xc0170, iriark01 and adbridge May 31, 2018

@@ -18,7 +18,8 @@
#define __UVISOR_DEPRECATION_H__
#if defined(UVISOR_PRESENT) && UVISOR_PRESENT == 1
#warning "Warning: You are using FEATURE_UVISOR, which is unsupported as of Mbed OS 5.9."
#warning "Warning: uVisor is superseded by the Secure Partition Manager (SPM) defined in the ARM Platform Security Architecture (PSA). \
uVisor is deprecated as of Mbed OS 5.9, and being replaced by a native PSA-compliant implementation of SPM."

This comment has been minimized.

@adbridge

adbridge May 31, 2018

Contributor

I think this should say 5.10. uvisor is still supported on the 5.9 branch so saying it is deprecated as of 5.9 is misleading.

This comment has been minimized.

@iriark01

iriark01 May 31, 2018

Contributor

Okay, then @ndevillard needs to reapprove the text with either 5.9 or 5.10

This comment has been minimized.

@orenc17

orenc17 May 31, 2018

Contributor

please just comment the message that you would like and let's finish with this annoyance

This comment has been minimized.

@ChiefBureaucraticOfficer

ChiefBureaucraticOfficer May 31, 2018

@ndevillard - I believe the agreement was deprecation notice in 5.9, actual deprecation in 5.10. So the notice should indicate 5.10.

This comment has been minimized.

@adbridge

adbridge May 31, 2018

Contributor

@orenc17 i think the 5.9 just needs to change to 5.10 and the rest is fine

This comment has been minimized.

@orenc17

orenc17 May 31, 2018

Contributor

@adbridge Done.

@cmonr

This comment has been minimized.

Contributor

cmonr commented May 31, 2018

/morph build

@cmonr

cmonr approved these changes May 31, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented May 31, 2018

Build : SUCCESS

Build number : 2208
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7072/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 3, 2018

ARM license issue.

Restarting pr-head.

@0xc0170

0xc0170 approved these changes Jun 4, 2018

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 4, 2018

@cmonr cmonr merged commit d559ed6 into ARMmbed:master Jun 4, 2018

13 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 919 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10202 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment