New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DNS resolution in case all sendto operations fail #7120

Merged
merged 1 commit into from Jun 7, 2018

Conversation

Projects
None yet
7 participants
@mikaleppanen
Contributor

mikaleppanen commented Jun 5, 2018

Description

DNS resolver now counts how many sendto operations are successful
during one DNS server attempt cycle (attempting to contact DNS
servers from 0 to last index, including stack specific ones). If all
socket sendto operations fail, DNS resolution is aborted.

If one or more are successful, DNS resolution is continued until
total network attempts count is reached or all sendto operations
fails during a cycle.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Fixed DNS resolution in case all sendto operations fail
DNS resolver now counts how many sendto operations are successful
during one DNS server attempt cycle (attempting to contact DNS
servers from 0 to last index, including stack specific ones). If all
socket sendto operations fail, DNS resolution is aborted.

If one or more are successful, DNS resolution is continued until
total network attempts count is reached or all sendto operations
fails during a cycle.
@mikaleppanen

This comment has been minimized.

Contributor

mikaleppanen commented Jun 5, 2018

@kjbracey-arm @TeroJaasko Please review.

@0xc0170

0xc0170 approved these changes Jun 5, 2018

@0xc0170 0xc0170 added the needs: CI label Jun 5, 2018

@TeroJaasko

This comment has been minimized.

Contributor

TeroJaasko commented Jun 6, 2018

@mikaleppanen looks good to me and the fix also works on my machine.

@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented Jun 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 7, 2018

Build : SUCCESS

Build number : 2260
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7120/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented Jun 7, 2018

/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit e10a3b3 into ARMmbed:master Jun 7, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 920 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10008 cycles (+44 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@kegilbert kegilbert removed the needs: CI label Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment