New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinetis EMAC: Make number of buffers configurable #7141

Merged
merged 2 commits into from Jun 11, 2018

Conversation

Projects
None yet
8 participants
@kjbracey-arm
Contributor

kjbracey-arm commented Jun 6, 2018

Description

16 RX buffers and 8 TX buffers is probably excessive. Nanostack version of driver ( https://github.com/ARMmbed/sal-nanostack-driver-k64f-eth ) successfully used 4+4, and data pump should be broadly equivalent.

This means that switching K64F devices from Nanostack to EMAC for 5.9 increases base heap usage by 18K - observed in Nanostack border router builds.

Add a config option to make it possible for border router and others to lower the number of buffers.

Defer consideration of lowering the default to later - leaving it as 16+8 for now.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented Jun 6, 2018

@0xc0170 0xc0170 requested a review from ARMmbed/team-nxp Jun 6, 2018

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:kinetis-mem-conf branch from a4c32f6 to eea7a98 Jun 6, 2018

kjbracey-arm added some commits Jun 6, 2018

Kinetis EMAC: Make number of buffers configurable
16 RX buffers and 8 TX buffers is probably excessive. Nanostack
version of driver successfully used 4+4, and data pump should be
broadly equivalent.

This means that switching K64F devices from Nanostack to EMAC increases
base heap usage by 18K - observed in Nanostack border router builds.

Add a config option to make it possible to lower the number of buffers.
Defer consideration of lowering the default to later.
Kinetis EMAC: Correct TX ring pointer array size
TX pointer array was using RX ring length in its declaration.
Wasted memory if RX ring > TX ring, as is the default, but would
be broken if RX ring < TX ring.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:kinetis-mem-conf branch from eea7a98 to a8e8775 Jun 6, 2018

@mmahadevan108

Thanks, looks good.

@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented Jun 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 7, 2018

Build : SUCCESS

Build number : 2262
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7141/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@artokin

artokin approved these changes Jun 7, 2018

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 7, 2018

Halting CI builds until RC3 PRs are completed. Will resume after.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 8, 2018

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 9, 2018

@0xc0170

0xc0170 approved these changes Jun 9, 2018

@cmonr cmonr merged commit 2ac81de into ARMmbed:master Jun 11, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 920 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9057 cycles (-890 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment