New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: Add setScanParams overload to the Gap API #7262

Merged
merged 3 commits into from Jun 22, 2018

Conversation

Projects
None yet
5 participants
@paul-szczepanek-arm
Member

paul-szczepanek-arm commented Jun 19, 2018

Description

Adding a missing overload for setScanParams so that it matches the advertising API calls.

Pull request type

[ ] Fix
[x] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

paul-szczepanek-arm added some commits Jun 19, 2018

@paul-szczepanek-arm paul-szczepanek-arm requested a review from pan- Jun 19, 2018

*/
ble_error_t setScanParams(const GapScanningParams& scanningParams) {
ble_error_t rc;
if (((rc = _scanningParams.setInterval(scanningParams.getInterval())) == BLE_ERROR_NONE) &&

This comment has been minimized.

@pan-

pan- Jun 19, 2018

Member

Could you delegate the call to setScanParams(uint16_t, uint16_t, uint16_t, bool) ?

@pan-

pan- approved these changes Jun 21, 2018

@cmonr

cmonr approved these changes Jun 21, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 21, 2018

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 21, 2018

@ARMmbed/mbed-os-maintainers This is a tricky PR to label.

A new function was added, but it's really just a mapping to a missing overloaded function call. I don't think it's enough of a user-facing change to warrant it going to 5.10. Thoughts?

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 22, 2018

Build : SUCCESS

Build number : 2429
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7262/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 22, 2018

Going to re-enqueue the export build since the failure appears to be something related to multiply-defined symbols, a CI issue we haven't seen in a while (ping @studavekar).

/morph export-build

@mbed-ci

This comment has been minimized.

@paul-szczepanek-arm

This comment has been minimized.

Member

paul-szczepanek-arm commented Jun 22, 2018

There's absolutely no rush to get this in. This is just a minor quality improvement.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 22, 2018

CI error, restarting

/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 22, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 22, 2018

@cmonr cmonr merged commit d18aa90 into ARMmbed:master Jun 22, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 919 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10180 cycles (+580 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment