New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On STM32F439xI IAR linker file decreased stack size and increased heap #7289

Merged
merged 1 commit into from Jul 31, 2018

Conversation

Projects
None yet
9 participants
@mikaleppanen
Contributor

mikaleppanen commented Jun 21, 2018

Description

On STM32F439xI IAR linker file decreased stack size from 24kbytes to 1kbytes (stack is used on boot-up/interrupt handler). Increased heap size from 65kbytes to 89kbytes.

Change is related to issue #7137 where UBLOX_EVK_ODIN_W2 runs out of heap on WLAN.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 21, 2018

@adbridge adbridge requested a review from ARMmbed/team-ublox Jun 21, 2018

@bulislaw

We are unifying ISR stack sizes to 1K across the boards (there are some exceptions Cortex A and NRF). Could you go straight to 1K please.

@bulislaw

This comment has been minimized.

Member

bulislaw commented Jun 22, 2018

#7238 changes to stack sizes and tests

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jun 22, 2018

On STM32F439xI IAR linker file decreased stack size and increased heap
Decreased stack size from 24kB to 1kB (stack is used on boot-up/interrupt
handler). Increased heap size from 65kB to 89kB.

Change is related to issue #7137
where UBLOX_EVK_ODIN_W2 runs out of heap on WLAN.

@mikaleppanen mikaleppanen force-pushed the mikaleppanen:odin_iar_heap_inc branch from 7f42c55 to 50a130b Jun 25, 2018

@mikaleppanen

This comment has been minimized.

Contributor

mikaleppanen commented Jun 25, 2018

Changed stack size to 1K.

@0xc0170 0xc0170 added needs: review and removed needs: work labels Jun 25, 2018

@asifrizwanubx

This comment has been minimized.

Contributor

asifrizwanubx commented Jun 26, 2018

why was the stack size earlier 24K?

@screamerbg

This comment has been minimized.

Member

screamerbg commented Jun 27, 2018

@mikaleppanen Could you please answer the question above so we could progress with the PR?

@mikaleppanen

This comment has been minimized.

Contributor

mikaleppanen commented Jun 27, 2018

@asifrizwanubx I do now know details. Looks like they were set to some default values based on memory size.

@asifrizwanubx

This comment has been minimized.

Contributor

asifrizwanubx commented Jun 27, 2018

is there any possiblity that this change will effect the behaviour of wifi drivers? I will test this PR with ublox internal tests and let you know if there is something wrong.

@mikaleppanen

This comment has been minimized.

Contributor

mikaleppanen commented Jun 27, 2018

@asifrizwanubx Ok, that sounds good. Change will affect ISR stack that is now 1K.

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Jun 27, 2018

@bulislaw Please review again, so this PR can proceed. Stack size have been changed as you requested.

@asifrizwanubx

This comment has been minimized.

Contributor

asifrizwanubx commented Jun 27, 2018

@mikaleppanen I have verifeid this and there is no bad impact on ublox internal test cases.

@mikaleppanen

This comment has been minimized.

Contributor

mikaleppanen commented Jun 27, 2018

@asifrizwanubx ok, thanks.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 27, 2018

One note, this settings affects also boards that are for mbed 2 - 1k stack is not enough there (this was also identified in 7238 and its being changed currently - the solution is to provide non rtos stack size bigger, see the Pr #7238 for more details).

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 24, 2018

The unification still is in progress . We shall proceed with this one.

@ARMmbed/team-st-mcd Please review (affecting also other targets). When I look at some F4 targets, they set __ICFEDIT_size_cstack__ to 0x1000 . Besides the unification, happy with the values here?

Updated to 1K

@bcostm

This comment has been minimized.

Contributor

bcostm commented Jul 25, 2018

LGTM

@bcostm

bcostm approved these changes Jul 25, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 25, 2018

@bulislaw Final approval? As requested this was set to 1K. I am afraid this is not sufficient for mbed 2 (this board is supported there).

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 27, 2018

The unification PR is progressing, this should be good to go (1k stack defined for IAR there as well).

/morph build

@0xc0170 0xc0170 added the needs: CI label Jul 27, 2018

@0xc0170 0xc0170 removed the needs: review label Jul 27, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 27, 2018

Build : SUCCESS

Build number : 2679
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7289/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 27, 2018

@cmonr cmonr merged commit d65abb6 into ARMmbed:master Jul 31, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 919 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8977 cycles (+215 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@mikaleppanen mikaleppanen deleted the mikaleppanen:odin_iar_heap_inc branch Aug 1, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7289 from mikaleppanen/odin_iar_heap_inc
On STM32F439xI IAR linker file decreased stack size and increased heap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment