New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_api script : separate PeripheralPins.o #7353

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
4 participants
@jeromecoutant
Contributor

jeromecoutant commented Jun 27, 2018

Description

This is done with @0xc0170 advice...
#7193 (comment)

Goal is to compile peripheral pins as separate object files in OS2

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@cmonr

cmonr approved these changes Jun 27, 2018

👍

@cmonr cmonr added the needs: CI label Jun 27, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 27, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 27, 2018

Build : SUCCESS

Build number : 2463
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7353/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 28, 2018

@cmonr cmonr merged commit 8baa8c5 into ARMmbed:master Jun 28, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 929 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9551 cycles (-434 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 29, 2018

@jeromecoutant Doing a review of another PR, it dawned on me that this PR addition didn't update the comment block above. Would you mind submitting another PR with a comment addressing what PeripheralPins.o is?

(I know what and why, but it's more about keeping in line with the existing documentation.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment