New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tool crashing when lines end with cr(not crlf) #7356

Merged
merged 1 commit into from Jun 28, 2018

Conversation

Projects
None yet
6 participants
@SenRamakri
Contributor

SenRamakri commented Jun 27, 2018

Description

Fix tool crashing when lines end with just cr (not crlf)

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@SenRamakri SenRamakri requested review from theotherjimmy and 0xc0170 Jun 27, 2018

@cmonr

cmonr approved these changes Jun 27, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 27, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 28, 2018

Build : SUCCESS

Build number : 2465
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7356/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 28, 2018

@cmonr cmonr merged commit cfe0789 into ARMmbed:master Jun 28, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 929 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9572 cycles (-413 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
@bmcdonnell-ionx

This comment has been minimized.

Contributor

bmcdonnell-ionx commented Jul 2, 2018

I see that your fix should handle CR, LF, and CRLF linebreaks, as described here. Nice. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment