Skip to content

Fix tool crashing when lines end with cr(not crlf) #7356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2018
Merged

Fix tool crashing when lines end with cr(not crlf) #7356

merged 1 commit into from
Jun 28, 2018

Conversation

SenRamakri
Copy link
Contributor

Description

Fix tool crashing when lines end with just cr (not crlf)

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@SenRamakri SenRamakri mentioned this pull request Jun 27, 2018
Closed
@cmonr
Copy link
Contributor

cmonr commented Jun 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

Build : SUCCESS

Build number : 2465
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7356/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

Exporter Build : SUCCESS

Build number : 2094
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7356/

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2018

Test : SUCCESS

Build number : 2241
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7356/2241

@cmonr cmonr merged commit cfe0789 into ARMmbed:master Jun 28, 2018
@bmcdonnell-ionx
Copy link
Contributor

I see that your fix should handle CR, LF, and CRLF linebreaks, as described here. Nice. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+2 more reviewers

@cmonr cmonr cmonr approved these changes

@theotherjimmy theotherjimmy theotherjimmy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 5.9.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SenRamakri @cmonr @mbed-ci @bmcdonnell-ionx @theotherjimmy @0xc0170