Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Summarize stats when depth is 0 #7377

Merged
merged 2 commits into from
Jul 5, 2018

Conversation

theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Jun 29, 2018

Description

#5153 describes an odd inconsistency in memap behavior, or at least where
my expectations were let down. It would print the entire memory map at full
depth when the depth was specified as 0. This PR changes that to print
something like:

+-----------+-------+-------+------+
| Module    | .text | .data | .bss |
+-----------+-------+-------+------+
| Subtotals | 38450 |  2564 | 7052 |
+-----------+-------+-------+------+

Resolves #5153

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

cmonr
cmonr previously approved these changes Jun 30, 2018
@cmonr
Copy link
Contributor

cmonr commented Jul 3, 2018

Fyi, this still needs to pass Travis.

@theotherjimmy
Copy link
Contributor Author

Errors reproduced. Fixing.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

Build : SUCCESS

Build number : 2526
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7377/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

@cmonr cmonr merged commit 0ba46e7 into ARMmbed:master Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants