New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clock source changeable over mbed_app.json for EFM32-Targets #7386

Merged
merged 1 commit into from Jul 5, 2018

Conversation

Projects
None yet
5 participants
@DBS06

DBS06 commented Jul 2, 2018

By adding the missing include the clock source for EFM32-Targets is changeable over mbed_app.json.

Description

Referencing issue #7346. Because nothing happens by silicon-labs regarding this issue I created this PR.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
PHST
Make clock source changeable over mbed_app.json
By adding the missing include the clock source for EFM32-Targets is changeable over mbed_app.json.

@0xc0170 0xc0170 requested a review from ARMmbed/team-silabs Jul 2, 2018

@0xc0170

0xc0170 approved these changes Jul 2, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 2, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 2, 2018

Build : SUCCESS

Build number : 2492
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7386/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@stevew817

This comment has been minimized.

Contributor

stevew817 commented Jul 2, 2018

LGTM, thanks @DBS06 for the PR.

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 2, 2018

/morph export-build
/morph mbed2-build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 2, 2018

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 3, 2018

/morph export-build

1 similar comment
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 3, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

1 similar comment
@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 3, 2018

We are experiencing CI machine error, investigating and restarting once fixed

cc @OPpuolitaival @studavekar

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 4, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 4, 2018

@cmonr cmonr merged commit 513960f into ARMmbed:master Jul 5, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 913 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10153 cycles (-567 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment