Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIMXRT1050_EVK: Move clock enable after check of pin #7421

Merged
merged 1 commit into from Jul 6, 2018
Merged

MIMXRT1050_EVK: Move clock enable after check of pin #7421

merged 1 commit into from Jul 6, 2018

Conversation

mmahadevan108
Copy link
Contributor

Description

MIMXRT1050_EVK: Move clock enable after check of pin. Enable clock could return an error if pin is NC

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@mmahadevan108
Copy link
Contributor Author

cc @0xc0170

0xc0170
0xc0170 previously approved these changes Jul 4, 2018
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 4, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

Build : SUCCESS

Build number : 2530
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7421/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

Test : SUCCESS

Build number : 2292
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7421/2292

@mbed-ci
Copy link

mbed-ci commented Jul 4, 2018

Exporter Build : SUCCESS

Build number : 2178
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7421/

@mmahadevan108
MIMXRT1050_EVK: Move clock enable after check of pin
c24d158 
Enable clock could return an error if pin is NC

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
Copy link
Contributor Author

cc @cmonr Updated this PR to remove ;;

@cmonr
Copy link
Contributor

cmonr commented Jul 5, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 6, 2018

Build : SUCCESS

Build number : 2544
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7421/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 6, 2018

Exporter Build : SUCCESS

Build number : 2188
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7421/

@mbed-ci
Copy link

mbed-ci commented Jul 6, 2018

Test : SUCCESS

Build number : 2299
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7421/2299

@cmonr cmonr merged commit 39a7e5c into ARMmbed:master Jul 6, 2018
@mmahadevan108 mmahadevan108 deleted the Fix_MXRT_GPIO_API branch August 1, 2018 16:45
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7421 from codeauroraforum/Fix_MXRT_GPIO_API
9bee060 
MIMXRT1050_EVK: Move clock enable after check of pin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

Assignees
No one assigned
Labels
release-version: 5.9.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmahadevan108 @0xc0170 @mbed-ci @cmonr