New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate version header file in Mbed OS #7434

Merged
merged 1 commit into from Jul 13, 2018

Conversation

Projects
None yet
6 participants
@deepikabhavnani
Contributor

deepikabhavnani commented Jul 6, 2018

Description

Separate version header file to have version details in Mbed OS source.
Update System stats to fetch Mbed OS version.

Pull request type

[ ] Fix
[x] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

CC @adbridge @bulislaw

@cmonr cmonr added the needs: review label Jul 6, 2018

@cmonr cmonr requested review from 0xc0170, kjbracey-arm and adbridge Jul 6, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Jul 6, 2018

@deepikabhavnani These are 2 separate changes, albeit related. Please split into 2 PRs.

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:version_header branch from 2a44c2a to c136add Jul 6, 2018

@deepikabhavnani deepikabhavnani changed the title from Add version header file and update system stats to Separate version header file to have version details in Mbed OS source. Jul 6, 2018

@deepikabhavnani deepikabhavnani changed the title from Separate version header file to have version details in Mbed OS source. to Separate version header file in Mbed OS Jul 6, 2018

@adbridge

adbridge requested changes Jul 6, 2018 edited

Generally looks good, however when referencing macro parameters they should always have ( ) around them:
MBED_STATIC_ASSERT((MBED_VERSION >= MBED_ENCODE_VERSION(M,m,p))

M, m and p should be (M), (m) and (p)

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:version_header branch from c136add to 19a2cef Jul 6, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Jul 6, 2018

M, m and p should be (M), (m) and (p)

👍 Done

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Jul 6, 2018

Related: #4891

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 9, 2018

151515

Why was this number chosen for master? we might get there one day or not?

👍 for having separate version header file

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Jul 9, 2018

Why was this number chosen for master? we might get there one day or not?

We didn;t wanted default to be zero or empty defines, hence 0xF. But now I feel we can have it as 999999 as well..
@adbridge @0xc0170 - 999999 as default for master branch will be good?

@adbridge

This comment has been minimized.

Contributor

adbridge commented Jul 9, 2018

I'd be surprised if we ever get to a major version of 15 considering the major (no pun intended) changes involved in bumping that field! Though the actual number is irrelevant really. Perhaps 999999 might be better...

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:version_header branch from 19a2cef to 656c088 Jul 9, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Jul 9, 2018

Changed default version to 999999

@adbridge

This comment has been minimized.

Contributor

adbridge commented Jul 10, 2018

LGTM

@0xc0170 0xc0170 requested a review from bulislaw Jul 10, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 11, 2018

* @note: Version of master branch will be 999999 as default, hence no assert/warning is provided for
* master branch code
*/
#define MBED_VERSION_CHECK(M,m,p) do { \

This comment has been minimized.

@bulislaw

bulislaw Jul 11, 2018

Member

Can we change the parameters to full spelled out version lik in MBED_ENCODE_VERSION

This comment has been minimized.

@deepikabhavnani

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:version_header branch from 656c088 to 05d8c74 Jul 11, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 12, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 12, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 12, 2018

Build : SUCCESS

Build number : 2582
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7434/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 13, 2018

@cmonr

cmonr approved these changes Jul 13, 2018

@cmonr cmonr merged commit 6fcb77e into ARMmbed:master Jul 13, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 791 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10233 cycles (+631 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:version_header branch Jul 13, 2018

@cmonr cmonr referenced this pull request Aug 3, 2018

Open

#defines for git info #6897

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment