New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable LSE for MTB_USI_WM_BN_BM_22 #7446

Merged
merged 1 commit into from Jul 11, 2018

Conversation

Projects
None yet
5 participants
@kivaisan
Contributor

kivaisan commented Jul 9, 2018

Description

Current MTB_USI_WM_BN_BM_22 modules do not have OSC32_IN connected, so
external xtal is not in use.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Jul 9, 2018

This fixes #6591 for MTB_USI_WM_BN_BM_22 target.

@0xc0170

0xc0170 approved these changes Jul 9, 2018

@0xc0170 0xc0170 requested a review from ashok-rao Jul 9, 2018

@@ -1193,6 +1193,7 @@
}
},
"MTB_USI_WM_BN_BM_22": {
"overrides": {"lse_available": 0},

This comment has been minimized.

@ashok-rao

ashok-rao Jul 9, 2018

Contributor

Thanks @kivaisan ..

  1. I think this will also be the case for MTB_ADV_WISE_1530 as well. Can you please check the schematics for 1530 and move this to the parent target if suitable?
  2. Minor nit on coding standards.. can you please follow coding conventions for 1 statement per line?
Disable LSE for MTB_USI_WM_BN_BM_22
Current MTB_USI_WM_BN_BM_22 modules do not have OSC32_IN connected, so
external xtal is not in use.

@kivaisan kivaisan force-pushed the kivaisan:disable_lse_MTB_USI_WM_BN_BM_22 branch from 891703d to a5ac795 Jul 10, 2018

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Jul 10, 2018

@ashok-rao WISE-1530 RTC tests (atleast the ones reported in MBEDOSTEST-24) works ok with LSE. And according to its datasheet, it should have the external xtal installed. Therefore I wouldn't put the setting to parent but just to module specific configuration.
Also modified the commit to follow coding standards.

@ashok-rao

LGTM! Thanks @kivaisan

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jul 11, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Jul 11, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Jul 11, 2018

Build : SUCCESS

Build number : 2565
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7446/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit dc946b3 into ARMmbed:master Jul 11, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 791 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10134 cycles (-27 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Jul 11, 2018

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

Merge pull request ARMmbed#7446 from kivaisan/disable_lse_MTB_USI_WM_…
…BN_BM_22

Disable LSE for MTB_USI_WM_BN_BM_22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment